From 1be95237ba2d969ae492183d7198a6ae6d5402e2 Mon Sep 17 00:00:00 2001 From: Lucy Date: Thu, 22 May 2025 05:45:50 -0400 Subject: [PATCH] Removes the Windows Build CI (#91186) ## About The Pull Request mothblocks told me to so I'm removing the Windows Build CI ## Why It's Good For The Game this causes nothing but problems. ## Changelog no user-facing changes --- .github/guides/CI.md | 4 ++-- .github/workflows/ci_suite.yml | 9 +-------- .github/workflows/test_windows.yml | 29 ----------------------------- 3 files changed, 3 insertions(+), 39 deletions(-) delete mode 100644 .github/workflows/test_windows.yml diff --git a/.github/guides/CI.md b/.github/guides/CI.md index e71c2145bab..d9cb429982d 100644 --- a/.github/guides/CI.md +++ b/.github/guides/CI.md @@ -30,9 +30,9 @@ You can also see the errors on the "Files Changed" tab of your pull request. Linter failures are usually very easy to fix, and will hopefully be clear from the message alone. -## Compile Maps / Windows Build +## Compile Maps -These two check nothing more than that your code actually compiles, with slightly different requirements. Compile Maps forces all maps (including space ruins etc) to be compiled in, to make sure all of them are valid, and Windows Build makes sure your code actually compiles on Windows. If these tests pass, but other tests fail, it means your code *compiles* but not necessarily that it *works*. +This checks nothing more than that your code actually compiles, with slightly different requirements. Compile Maps forces all maps (including space ruins etc) to be compiled in, to make sure all of them are valid. If these tests pass, but other tests fail, it means your code *compiles* but not necessarily that it *works*. ## Integration Tests diff --git a/.github/workflows/ci_suite.yml b/.github/workflows/ci_suite.yml index 487a64493aa..33432173904 100644 --- a/.github/workflows/ci_suite.yml +++ b/.github/workflows/ci_suite.yml @@ -75,17 +75,10 @@ jobs: name: Compare Screenshot Tests uses: ./.github/workflows/compare_screenshots.yml - test_windows: - name: Windows Build - needs: collect_data - uses: ./.github/workflows/test_windows.yml - with: - max_required_byond_client: ${{needs.collect_data.outputs.max_required_byond_client}} - completion_gate: # Serves as a non-moving target for branch rulesets if: always() && !cancelled() name: Completion Gate - needs: [ test_windows, compare_screenshots, compile_all_maps, run_all_tests, run_alternate_tests, run_linters ] + needs: [ compare_screenshots, compile_all_maps, run_all_tests, run_alternate_tests, run_linters ] runs-on: ubuntu-latest steps: - name: Decide whether the needed jobs succeeded or failed diff --git a/.github/workflows/test_windows.yml b/.github/workflows/test_windows.yml deleted file mode 100644 index a437a067b71..00000000000 --- a/.github/workflows/test_windows.yml +++ /dev/null @@ -1,29 +0,0 @@ -name: Test Windows - -on: - workflow_call: - inputs: - max_required_byond_client: - required: true - type: string - -jobs: - test_windows: - runs-on: windows-latest - timeout-minutes: 5 - - steps: - - uses: actions/checkout@v4 - - name: Setup Node - uses: ./.github/actions/setup_node - with: - restore-yarn-cache: true - - name: Compile - run: pwsh tools/ci/build.ps1 - env: - DM_EXE: "C:\\byond\\bin\\dm.exe" - - name: Check client Compatibility - uses: tgstation/byond-client-compatibility-check@v3 - with: - dmb-location: tgstation.dmb - max-required-client-version: ${{inputs.max_required_byond_client}}