From 1bf2d595b4975e415fc01065785bb144533a51d3 Mon Sep 17 00:00:00 2001
From: SkyratBot <59378654+SkyratBot@users.noreply.github.com>
Date: Sat, 10 Dec 2022 05:42:12 +0100
Subject: [PATCH] [MIRROR] Fixes fake links in Adminwho that led to
 "no_feedback_link" [MDB IGNORE] (#18027)

* Fixes fake links in Adminwho that led to "no_feedback_link" (#71804)

## About The Pull Request
Basically, sometimes, very rarely, it was possible for this to happen,
when it shouldn't be happening. I was wondering for a little while what
it was about, and then I finally downloaded my chat logs for a round and
realized what was going on. It should no longer happen.

## Why It's Good For The Game
Clickable links that lead nowhere (and thus don't do anything) aren't
very good for the game.

## Changelog

:cl: GoldenAlpharex
fix: There shouldn't be clickable names in Adminwho that don't do
anything anymore.
/:cl:

* Fixes fake links in Adminwho that led to "no_feedback_link"

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
---
 code/modules/admin/holder2.dm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/code/modules/admin/holder2.dm b/code/modules/admin/holder2.dm
index 952b9b263b2..9091ce8e211 100644
--- a/code/modules/admin/holder2.dm
+++ b/code/modules/admin/holder2.dm
@@ -196,6 +196,9 @@ GLOBAL_PROTECT(href_token)
 	cached_feedback_link = feedback_query.item[1] || NO_FEEDBACK_LINK
 	qdel(feedback_query)
 
+	if (cached_feedback_link == NO_FEEDBACK_LINK) // Because we don't want to send fake clickable links.
+		return null
+
 	return cached_feedback_link
 
 /datum/admins/proc/check_for_rights(rights_required)