cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-23 21:18:37 +01:00
Code Issues Packages Projects Releases Wiki Activity

Initializes on_finish_callbacks in the JPS move loop (#79505)

Browse Source 
## About The Pull Request

The on_finish_callbacks list in `/datum/move_loop/has_target/jps` was
not initialized. Usually, when you add something to an uninitialized
list, it gets initialized and the item gets added to it. However, the
`CALLBACK` wrapper is around `new /datum/callback`, this fails.

This meant on_finish_callback was not a list, therefore at the end of
pathfinding, its contents could not be iterated and invoked. This PR
fixes this problem by initializing the list.

## Why It's Good For The Game

Closes #79383
Blob minions rally and punch again. 

## Changelog

🆑
fix: Basic mobs using JPS can move again
/🆑
This commit is contained in:
Profakos
2023-11-04 16:03:09 -06:00
committed by GitHub
parent 89e918df78
commit 1e8507e154
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/controllers/subsystem/movement/movement_types.dm
+1 -1
View File
@@ -367,7 +367,7 @@
///Bool used to determine if we're already making a path in JPS. this prevents us from re-pathing while we're already busy.
var/is_pathing = FALSE
///Callbacks to invoke once we make a path
var/list/datum/callback/on_finish_callbacks
var/list/datum/callback/on_finish_callbacks = list()
/datum/move_loop/has_target/jps/New(datum/movement_packet/owner, datum/controller/subsystem/movement/controller, atom/moving, priority, flags, datum/extra_info)
. = ..()