[MIRROR] Nerfs bone wounds to make them less miserable (#8245)

* Nerfs bone wounds to make them less miserable (#61196)

So I've always kinda known that bone wounds are unpleasant to receive, but since paying some closer attention to how they affect peoples rounds in the last few months, I've realized that they need to be reigned in some more. So, let's break down the big changes...
General bone wound nerfs

Limping on a busted leg is now a chance with each step of that leg, instead of always happening: No matter how small the delay added to your move time after each step (like if it was just a dislocation), and even with slings, bone wounds on your leg crippled you with the constant slowdown, because they happened every time you stepped on that leg. Now, the chance to limp on any given step with that leg is higher with worse wounds, and applying a sling to that leg further lowers that chance, as well as lowering the delay from that limp. A dislocated leg, for example, only limps 30% of the time, while a compound fracture limps 70% of the time.

Skeletons and plasmamen (aka carbons with no flesh) can now use bone gel directly on cracked limbs to fix them, in 1/4th the time it takes the normal bone gel + surgical tape improvised fix to heal them, and with none of the damage. I felt bad that the ability for skeletons to stick dismembered limbs back into their slots was destroyed because the limbs would be critically wounded already, and still useless. Now, skeletons and plasmamen can be treated with just bone gel and some time. At some point after this is merged, someone should give the pirate ship some free bone gel.

The speed of the improvised bone gel + surgical fix for broken bones is even further improved by laying down and by sleeping than it was before, meaning the improvised fixes can be cut down further by laying down for a bit while it works.

Makes bone wounds less obnoxious, reducing their ability to single-handedly ruin your round when you suffer one. I want to go further in the future and add an easier improvised fix for hairline fractures soon, but those changes can come later after these are merged.

* Nerfs bone wounds to make them less miserable

Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>

code/datums/status_effects/wound_effects.dm

@@ -27,7 +27,7 @@
 /datum/status_effect/limp
 	id = "limp"
 	status_type = STATUS_EFFECT_REPLACE
-	tick_interval = 10
+	tick_interval = 0
 	alert_type = /atom/movable/screen/alert/status_effect/limp
 	var/msg_stage = 0//so you dont get the most intense messages immediately
 	/// The left leg of the limping person
@@ -40,6 +40,10 @@
 	var/slowdown_left = 0
 	/// How many deciseconds we limp for on the right leg
 	var/slowdown_right = 0
+	/// The chance we limp with the left leg each step it takes
+	var/limp_chance_left = 0
+	/// The chance we limp with the right leg each step it takes
+	var/limp_chance_right = 0
 
 /datum/status_effect/limp/on_apply()
 	if(!iscarbon(owner))
@@ -64,14 +68,17 @@
 
 	if(!owner.client || owner.body_position == LYING_DOWN || !owner.has_gravity() || (owner.movement_type & FLYING) || forced || owner.buckled)
 		return
+
 	// less limping while we have determination still
-	var/determined_mod = owner.has_status_effect(STATUS_EFFECT_DETERMINED) ? 0.25 : 1
+	var/determined_mod = owner.has_status_effect(STATUS_EFFECT_DETERMINED) ? 0.5 : 1
 
 	if(next_leg == left)
-		owner.client.move_delay += slowdown_left * determined_mod
+		if(prob(limp_chance_left * determined_mod))
+			owner.client.move_delay += slowdown_left * determined_mod
 		next_leg = right
 	else
-		owner.client.move_delay += slowdown_right * determined_mod
+		if(prob(limp_chance_right * determined_mod))
+			owner.client.move_delay += slowdown_right * determined_mod
 		next_leg = left
 
 /datum/status_effect/limp/proc/update_limp()
@@ -87,16 +94,21 @@
 
 	slowdown_left = 0
 	slowdown_right = 0
+	limp_chance_left = 0
+	limp_chance_right = 0
 
+	// technically you can have multiple wounds causing limps on the same limb, even if practically only bone wounds cause it in normal gameplay
 	if(left)
 		for(var/thing in left.wounds)
 			var/datum/wound/W = thing
 			slowdown_left += W.limp_slowdown
+			limp_chance_left = max(limp_chance_left, W.limp_chance)
 
 	if(right)
 		for(var/thing in right.wounds)
 			var/datum/wound/W = thing
 			slowdown_right += W.limp_slowdown
+			limp_chance_right = max(limp_chance_right, W.limp_chance)
 
 	// this handles losing your leg with the limp and the other one being in good shape as well
 	if(!slowdown_left && !slowdown_right)