cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-07-19 20:15:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Fixes the formatting for ghost PDA messages [MDB IGNORE] (#23079)

Browse Source 
* Fixes the formatting for ghost PDA messages (#77590)

## About The Pull Request
It was in all bold, now it no longer is. It also was only being
displayed to dedicated observers, which means that it didn't show to
players that died and ghosted out.

![image](https://github.com/tgstation/tgstation/assets/58045821/8f00197e-1911-461f-a819-7debb0f622e2)

## Why It's Good For The Game
It's just much nicer, and looks like it used to look before, rather than
being entirely bold.

## Changelog

🆑 GoldenAlpharex
fix: The formatting on PDA messages displayed to observers is now back
to what it used to be, rather than being all bold.
fix: PDA messages are now displayed to observers from dead players, and
not just dedicated observers.
/🆑

---------

Co-authored-by: distributivgesetz <distributivgesetz93@ gmail.com>

* Fixes the formatting for ghost PDA messages

---------

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
Co-authored-by: distributivgesetz <distributivgesetz93@ gmail.com>
This commit is contained in:
SkyratBot
2023-08-15 01:07:00 +02:00
committed by GitHub
parent 286cf2d8bb
commit 23abc88065
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/modular_computers/file_system/programs/messenger/messenger_program.dm
+3 -2
View File
@@ -612,8 +612,9 @@
message = emoji_parse(message) //already sent- this just shows the sent emoji as one to the sender in the to_chat
// Show it to ghosts
var/ghost_message = span_name("[sender] [rigged ? "(as [fake_name]) Rigged " : ""]PDA Message --> [span_name("[signal.format_target()]")]: \"[signal.format_message()]\"")
for(var/mob/player_mob as anything in GLOB.current_observers_list)
var/ghost_message = span_game_say("[span_name("[sender]")] [rigged ? "(as [span_name(fake_name)]) Rigged " : ""]PDA Message --> [span_name("[signal.format_target()]")]: \"[signal.format_message()]\"")
var/list/ghosts = GLOB.dead_player_list + GLOB.current_observers_list
for(var/mob/player_mob as anything in ghosts)
if(player_mob.client && !player_mob.client?.prefs)
stack_trace("[player_mob] ([player_mob.ckey]) had null prefs, which shouldn't be possible!")
continue