mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-07-13 09:05:11 +01:00
Fixes improper static list declarations + adds grep for it (#87207)
## About The Pull Request I randomly came across a `var/list/static` in the code, which does not actually do what was intended, and thought it was silly. A ctrl+f revealed that this was a fairly common mistake, so I went and fixed all the instances of it I could find. ~~Including one in lighting code, which it looked like they were trying to create a global list to cache generated lighting sheet values for speed, but it was just a normal list that got created each time pointlessly. Now those values are actually being cached (using a global var, because a `static` list was not the right thing to use there in the first place).~~ Nevermind, it seems that this was in fact being cached even if it shouldn't have been, because byond. Just rearranged it there seeing as it works either way. ## Why It's Good For The Game Code that does what it's supposed to ## Changelog 🆑 fix: fixes a bunch of improper static list declarations /🆑
This commit is contained in:
@@ -38,7 +38,7 @@
|
||||
. = ..()
|
||||
|
||||
/// Static list of all minerals to populate gulag boulders with.
|
||||
var/list/static/gulag_minerals = list(
|
||||
var/static/list/gulag_minerals = list(
|
||||
/datum/material/diamond = 1,
|
||||
/datum/material/gold = 8,
|
||||
/datum/material/iron = 95,
|
||||
@@ -59,7 +59,7 @@
|
||||
. = ..()
|
||||
|
||||
/// Static list of all minerals to populate gulag boulders with, but with bluespace added where safe.
|
||||
var/list/static/expanded_gulag_minerals = list(
|
||||
var/static/list/expanded_gulag_minerals = list(
|
||||
/datum/material/bluespace = 1,
|
||||
/datum/material/diamond = 1,
|
||||
/datum/material/gold = 8,
|
||||
|
||||
Reference in New Issue
Block a user