removes alot of click-related self registering signals on basic mobs (#87220)

## About The Pull Request
there was no real benefit of using signals over proc overrides for many
of these cases.

## Why It's Good For The Game
registering signals on self when we can just override the proc is
un-necessary, im responsible for most of these so im just confronting
the sins of my past

## Changelog
🆑
/🆑
This commit is contained in:
Ben10Omintrix
2024-10-15 21:58:20 +02:00
committed by GitHub
parent 6e21331367
commit 2438ff0213
18 changed files with 158 additions and 164 deletions
@@ -45,8 +45,6 @@
AddComponent(/datum/component/basic_mob_ability_telegraph)
AddComponent(/datum/component/basic_mob_attack_telegraph, telegraph_duration = 0.6 SECONDS)
RegisterSignal(src, COMSIG_HOSTILE_PRE_ATTACKINGTARGET, PROC_REF(pre_attack))
var/static/list/innate_actions = list(
/datum/action/cooldown/mob_cooldown/fire_breath/ice = BB_WHELP_STRAIGHTLINE_FIRE,
/datum/action/cooldown/mob_cooldown/fire_breath/ice/cross = BB_WHELP_WIDESPREAD_FIRE,
@@ -55,22 +53,24 @@
grant_actions_by_list(innate_actions)
/mob/living/basic/mining/ice_whelp/proc/pre_attack(mob/living/sculptor, atom/target)
SIGNAL_HANDLER
/mob/living/basic/mining/ice_whelp/early_melee_attack(atom/target, list/modifiers, ignore_cooldown)
. = ..()
if(!.)
return FALSE
if(istype(target, /obj/structure/flora/rock/icy))
INVOKE_ASYNC(src, PROC_REF(create_sculpture), target)
return COMPONENT_HOSTILE_NO_ATTACK
create_sculpture(target)
return FALSE
if(!istype(target, src.type))
return
if(!istype(target, type))
return TRUE
var/mob/living/victim = target
if(victim.stat != DEAD)
return
return TRUE
INVOKE_ASYNC(src, PROC_REF(cannibalize_victim), victim)
return COMPONENT_HOSTILE_NO_ATTACK
cannibalize_victim(victim)
return FALSE
/// Carve a stone into a beautiful self-portrait
/mob/living/basic/mining/ice_whelp/proc/create_sculpture(atom/target)