cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-26 22:50:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

Deletes handle_random_events, saving us from 1 whole proc call in Life (#83421)

Browse Source 
## About The Pull Request

Dumps `handle_random_events` in the bin, giving us one less proc in
`Life`, that's a free proc call optimization baby.

Replaces its only implementation with a status effect conditionally
applied when gaining / losing tox dam.

## Changelog

🆑 Melbert
refactor: Refactored the way high toxins cause you to vomit.
/🆑
This commit is contained in:
MrMelbert
2024-05-26 11:58:16 -07:00
committed by GitHub
parent e2f011466a
commit 249df48116
9 changed files with 79 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/unit_tests/mob_damage.dm
+19
View File
@@ -580,3 +580,22 @@
if(!verify_damage(gusgus, 0, included_types = BRUTELOSS))
TEST_FAIL("heal_overall_damage did not apply its healing correctly on the mouse!")
/// Tests that humans get the tox_vomit status effect when heavily poisoned
/datum/unit_test/human_tox_damage
/datum/unit_test/human_tox_damage/Run()
// Spawn a dummy, give it a bunch of tox damage. It should get the status effect.
var/mob/living/carbon/human/dummy = allocate(/mob/living/carbon/human/consistent)
dummy.setToxLoss(75)
var/datum/status_effect/tox_effect = dummy.has_status_effect(/datum/status_effect/tox_vomit)
TEST_ASSERT_NOTNULL(tox_effect, "Dummy didn't get tox_vomit status effect despite at [dummy.getToxLoss()] toxin damage (Method: SET)!")
// Clear the toxin damage away, and force a status effect tick: It should delete itself
dummy.setToxLoss(0)
tox_effect.tick(initial(tox_effect.tick_interval))
TEST_ASSERT(QDELETED(tox_effect), "Dummy still has tox_vomit status effect despite at [dummy.getToxLoss()] toxin damage (Method: SET)!")
// Test another method of gaining tox damage, use an entirely clean slate just to be sure
var/mob/living/carbon/human/dummy_two = allocate(/mob/living/carbon/human/consistent)
dummy_two.adjustToxLoss(75)
var/datum/status_effect/tox_effect_two = dummy_two.has_status_effect(/datum/status_effect/tox_vomit)
TEST_ASSERT_NOTNULL(tox_effect_two, "Dummy didn't get tox_vomit status effect at [dummy_two.getToxLoss()] toxin damage (METHOD: ADJUST)!")