cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-01-05 22:43:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace deprecated PHP syntax in webhook processor (#55546)

Browse Source 
Line 17 of the Run Linters job of the CI Suite workflow:

> PHP Fatal error: Array and string offset access syntax with curly braces is
> no longer supported in ./tools/WebhookProcessor/github_webhook_processor.php
> on line 972

Something, something the PHP version updated to 7.x and dropped curly brackets support.
This commit is contained in:
Ghom
2020-12-16 02:16:44 +01:00
committed by GitHub
parent c328c375d9
commit 2793d89f81
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tools/WebhookProcessor/github_webhook_processor.php
View File

@@ -969,7 +969,7 @@ function checkchangelog($payload, $compile = true) {
function game_server_send($addr, $port, $str) { function game_server_send($addr, $port, $str) {
// All queries must begin with a question mark (ie "?players") // All queries must begin with a question mark (ie "?players")
if($str{0} != '?') $str = ('?' . $str); if($str[0] != '?') $str = ('?' . $str);
/* --- Prepare a packet to send to the server (based on a reverse-engineered packet structure) --- */ /* --- Prepare a packet to send to the server (based on a reverse-engineered packet structure) --- */
$query = "\x00\x83" . pack('n', strlen($str) + 6) . "\x00\x00\x00\x00\x00" . $str . "\x00"; $query = "\x00\x83" . pack('n', strlen($str) + 6) . "\x00\x00\x00\x00\x00" . $str . "\x00";
@@ -999,23 +999,23 @@ function game_server_send($addr, $port, $str) {
socket_close($server); // we don't need this anymore socket_close($server); // we don't need this anymore
if($result != "") { if($result != "") {
if($result{0} == "\x00" || $result{1} == "\x83") { // make sure it's the right packet format if($result[0] == "\x00" || $result[1] == "\x83") { // make sure it's the right packet format
// Actually begin reading the output: // Actually begin reading the output:
$sizebytes = unpack('n', $result{2} . $result{3}); // array size of the type identifier and content $sizebytes = unpack('n', $result[2] . $result[3]); // array size of the type identifier and content
$size = $sizebytes[1] - 1; // size of the string/floating-point (minus the size of the identifier byte) $size = $sizebytes[1] - 1; // size of the string/floating-point (minus the size of the identifier byte)
if($result{4} == "\x2a") { // 4-byte big-endian floating-point if($result[4] == "\x2a") { // 4-byte big-endian floating-point
$unpackint = unpack('f', $result{5} . $result{6} . $result{7} . $result{8}); // 4 possible bytes: add them up together, unpack them as a floating-point $unpackint = unpack('f', $result[5] . $result[6] . $result[7] . $result[8]); // 4 possible bytes: add them up together, unpack them as a floating-point
return $unpackint[1]; return $unpackint[1];
} }
else if($result{4} == "\x06") { // ASCII string else if($result[4] == "\x06") { // ASCII string
$unpackstr = ""; // result string $unpackstr = ""; // result string
$index = 5; // string index $index = 5; // string index
while($size > 0) { // loop through the entire ASCII string while($size > 0) { // loop through the entire ASCII string
$size--; $size--;
$unpackstr .= $result{$index}; // add the string position to return string $unpackstr .= $result[$index]; // add the string position to return string
$index++; $index++;
} }
return $unpackstr; return $unpackstr;