From 288c3a606a487fb1f0fda8869967d67f3e2a762d Mon Sep 17 00:00:00 2001 From: Leland Kemble <70413276+lelandkemble@users.noreply.github.com> Date: Tue, 11 Nov 2025 21:27:24 -0500 Subject: [PATCH] Adds self-message to clown pockets spell, calls post_created() (#93885) ## About The Pull Request Adds self-message to the clown pockets spell that lets you pull out clown items from nowhere. Also, calls `post_created()` in `/datum/action/cooldown/spell/conjure_item`, which it wasn't before. ## Why It's Good For The Game I don't like seeing my own name in the chatbox from my own actions. `post_created()` currently is useless. It's still useless, cause it's only for this spell, but its a lesser degree of uselessness. ## Changelog :cl: spellcheck: Adds self-message to clown pockets spell /:cl: --- .../antagonists/wizard/equipment/enchanted_clown_suit.dm | 8 +++++--- .../spells/spell_types/conjure_item/_conjure_item.dm | 2 ++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/code/modules/antagonists/wizard/equipment/enchanted_clown_suit.dm b/code/modules/antagonists/wizard/equipment/enchanted_clown_suit.dm index 62397127693..c0ae9379f1b 100644 --- a/code/modules/antagonists/wizard/equipment/enchanted_clown_suit.dm +++ b/code/modules/antagonists/wizard/equipment/enchanted_clown_suit.dm @@ -62,7 +62,7 @@ return ..() /datum/action/cooldown/spell/conjure_item/clown_pockets/post_created(atom/cast_on, atom/created) - cast_on.visible_message(span_notice("[cast_on] pulls out [created]!")) + cast_on.visible_message(span_notice("[cast_on] pulls out [created]!"), span_notice("You pull out [created]!")) /datum/action/cooldown/spell/conjure_item/clown_pockets/can_cast_spell(feedback = TRUE) . = ..() @@ -76,7 +76,8 @@ /// Prints a funny message, exists so I can override it to print a different message /datum/action/cooldown/spell/conjure_item/clown_pockets/proc/cast_message(mob/cast_on) cast_on.visible_message(span_notice("[cast_on] reaches far deeper into [cast_on.p_their()] pockets than you think \ - should be possible and starts rummaging around for something.")) + should be possible and starts rummaging around for something."), span_notice("You reach further down into your \ + pockets than you ever have before and feel around for something.")) /// Longer cooldown variant which is attached to the enchanted clown suit /datum/action/cooldown/spell/conjure_item/clown_pockets/enchantment @@ -84,7 +85,8 @@ cooldown_time = 60 SECONDS /datum/action/cooldown/spell/conjure_item/clown_pockets/enchantment/cast_message(mob/cast_on) - cast_on.visible_message(span_notice("[cast_on] starts rummaging around in [cast_on.p_their()] comically large pants.")) + cast_on.visible_message(span_notice("[cast_on] starts rummaging around in [cast_on.p_their()] comically large pants."), span_notice("You \ + start rummaging around in your comically large pants.")) /// Enchanted clown suit /obj/item/clothing/under/rank/civilian/clown/magic diff --git a/code/modules/spells/spell_types/conjure_item/_conjure_item.dm b/code/modules/spells/spell_types/conjure_item/_conjure_item.dm index 3bbdf25fa84..95616c54360 100644 --- a/code/modules/spells/spell_types/conjure_item/_conjure_item.dm +++ b/code/modules/spells/spell_types/conjure_item/_conjure_item.dm @@ -72,6 +72,8 @@ if(istype(mob_caster)) mob_caster.put_in_hands(created, del_on_fail = delete_on_failure) + post_created(cast_on, created) + return ..() /// Instantiates the item we're conjuring and returns it.