[MIRROR] Fixes job preference entries persisting after they have been nulled [MDB IGNORE] (#16968)

* Fixes job preference entries persisting after they have been nulled (#70577)

I know this doesn't actually change behavior, but it's confusing, and
adds a potential point of failure if someone doesn't realize it can
happen. Let's be consistent

* Fixes job preference entries persisting after they have been nulled

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
This commit is contained in:
SkyratBot
2022-10-19 11:26:05 +01:00
committed by GitHub
co-authored by LemonInTheDark
parent d790d9318a
commit 293a5ed27f
+4 -1
View File
@@ -500,7 +500,10 @@ GLOBAL_LIST_EMPTY(preferences_datums)
else
job_preferences[other_job] = JP_MEDIUM
job_preferences[job.title] = level
if(level == null)
job_preferences -= job.title
else
job_preferences[job.title] = level
return TRUE