cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-07-19 12:05:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Fixes an issue with the "recolor from string" option in the greyscale modify menu [MDB IGNORE] (#23365)

Browse Source 
* Fixes an issue with the "recolor from string" option in the greyscale modify menu (#77798)

## About The Pull Request
The number of colors has to match the expected color of the greyscale
configuration, otherwise the whole proc chain behind the generation of
the resulting icon will crash here:
https://github.com/tgstation/tgstation/blob/ac446d8bad3596016217112a53fe91b8140dace2/code/datums/greyscale/_greyscale_config.dm#L253

## Why It's Good For The Game
One of the thousands runtimes I've seen in the runtime viewer.

## Changelog

🆑
fix: Fixed an issue with the "recolor from string" option in the
greyscale modify menu that resulted in invisible icons.
/🆑

* Fixes an issue with the "recolor from string" option in the greyscale modify menu

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
This commit is contained in:
SkyratBot
2023-08-27 19:39:23 +02:00
committed by GitHub
parent eb452bf9bc
commit 2b154fd86e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/admin/greyscale_modify_menu.dm
+1 -1
View File
@@ -243,7 +243,7 @@ This is highly likely to cause massive amounts of lag as every object in the gam
/datum/greyscale_modify_menu/proc/ReadColorsFromString(colorString)
var/list/new_split_colors = list()
var/list/colors = splittext(colorString, "#")
for(var/index in 2 to length(colors))
for(var/index in 2 to min(length(colors), config.expected_colors + 1))
var/color = "#[colors[index]]"
if(!findtext(color, GLOB.is_color) && (!unlocked || !findtext(color, GLOB.is_alpha_color)))
return FALSE