Fixes SiliConnect not being able to download logs (#89408)

## About The Pull Request

Closes #89329
Also added a balloon_alert

## Changelog
🆑
qol: SiliConnect now informs you that you're successfully downloading
logs
fix: Fixes SiliConnect not being able to download logs
/🆑
This commit is contained in:
SmArtKar
2025-02-17 00:59:24 +01:00
committed by GitHub
parent a439e2379a
commit 2c3e3b6e59
8 changed files with 32 additions and 27 deletions
@@ -28,12 +28,12 @@
return COMPONENT_CANCEL_ATTACK_CHAIN
/// Keep this in sync with its tool based counterpart [/obj/proc/analyzer_act] and [/atom/proc/tool_act]
/datum/computer_file/program/atmosscan/tap(atom/A, mob/living/user, params)
/datum/computer_file/program/atmosscan/tap(atom/tapped_atom, mob/living/user, list/modifiers)
if(atmozphere_mode != ATMOZPHERE_SCAN_CLICK)
return FALSE
if(!atmos_scan(user=user, target=A, silent=FALSE))
if(!atmos_scan(user, tapped_atom))
return FALSE
on_analyze(source=computer, target=A)
on_analyze(computer, tapped_atom)
return TRUE
/// Updates our gasmix data if on click mode.
@@ -26,8 +26,8 @@
DL_progress = 0
return ..()
/datum/computer_file/program/borg_monitor/tap(atom/A, mob/living/user, params)
var/mob/living/silicon/robot/borgo = A
/datum/computer_file/program/borg_monitor/tap(atom/tapped_atom, mob/living/user, list/modifiers)
var/mob/living/silicon/robot/borgo = tapped_atom
if(!istype(borgo) || !borgo.modularInterface)
return FALSE
DL_source = borgo
@@ -39,6 +39,7 @@
username = "user [stored_card.registered_name]"
to_chat(borgo, span_userdanger("Request received from [username] for the system log file. Upload in progress."))//Damning evidence may be contained, so warn the borg
borgo.logevent("File request by [username]: /var/logs/syslog")
borgo.balloon_alert(user, "downloading logs")
return TRUE
/datum/computer_file/program/borg_monitor/process_tick(seconds_per_tick)
@@ -88,7 +88,7 @@
* Normally, modular PCs can be print paper already, but I find this additional step
* to be less lazy and fitting to the "I gotta go print it before it expires" aspect of it.
*/
/datum/computer_file/program/coupon/tap(atom/tapped_atom, mob/living/user, params)
/datum/computer_file/program/coupon/tap(atom/tapped_atom, mob/living/user, list/modifiers)
if(!istype(tapped_atom, /obj/machinery/photocopier))
return FALSE
var/obj/item/card/id/user_id = computer.computer_id_slot
@@ -35,7 +35,7 @@
QDEL_NULL(internal_picture)
return ..()
/datum/computer_file/program/maintenance/camera/tap(atom/tapped_atom, mob/living/user, params)
/datum/computer_file/program/maintenance/camera/tap(atom/tapped_atom, mob/living/user, list/modifiers)
. = ..()
if(internal_picture)
QDEL_NULL(internal_picture)
@@ -10,7 +10,7 @@
/// Information from the last scanned person, to display on the app.
var/last_record = ""
/datum/computer_file/program/maintenance/phys_scanner/tap(atom/tapped_atom, mob/living/user, params)
/datum/computer_file/program/maintenance/phys_scanner/tap(atom/tapped_atom, mob/living/user, list/modifiers)
. = ..()
if(!iscarbon(tapped_atom))