diff --git a/code/controllers/subsystem/garbage.dm b/code/controllers/subsystem/garbage.dm
index e88ed902656..37a8098397b 100644
--- a/code/controllers/subsystem/garbage.dm
+++ b/code/controllers/subsystem/garbage.dm
@@ -351,7 +351,6 @@ var/datum/subsystem/garbage_collector/SSgarbage
//if find_references isn't working for some datum
//update this list using tools/DMTreeToGlobalsList
/datum/proc/find_references_in_globals()
- SearchVar(failed_db_connections)
SearchVar(nextmap)
SearchVar(mapchanging)
SearchVar(rebootingpendingmapchange)
diff --git a/code/modules/admin/DB_ban/functions.dm b/code/modules/admin/DB_ban/functions.dm
index 50a6f972afe..3e35d83715d 100644
--- a/code/modules/admin/DB_ban/functions.dm
+++ b/code/modules/admin/DB_ban/functions.dm
@@ -6,8 +6,7 @@
if(!check_rights(R_BAN))
return
- establish_db_connection()
- if(!dbcon.IsConnected())
+ if(!dbcon.Connect())
src << "Failed to establish database connection."
return
@@ -183,8 +182,7 @@
if(job)
sql += " AND job = '[job]'"
- establish_db_connection()
- if(!dbcon.IsConnected())
+ if(!dbcon.Connect())
return
var/ban_id
@@ -280,8 +278,7 @@
var/sql = "SELECT ckey FROM [format_table_name("ban")] WHERE id = [id]"
- establish_db_connection()
- if(!dbcon.IsConnected())
+ if(!dbcon.Connect())
return
var/ban_number = 0 //failsafe
@@ -333,8 +330,7 @@
if(!check_rights(R_BAN))
return
- establish_db_connection()
- if(!dbcon.IsConnected())
+ if(!dbcon.Connect())
usr << "Failed to establish database connection."
return
diff --git a/code/modules/admin/IsBanned.dm b/code/modules/admin/IsBanned.dm
index 725a3332112..7e1b8f038b6 100644
--- a/code/modules/admin/IsBanned.dm
+++ b/code/modules/admin/IsBanned.dm
@@ -61,7 +61,7 @@
var/ckeytext = ckey(key)
- if(!establish_db_connection())
+ if(!dbcon.Connect())
log_world("Ban database connection failure. Key [ckeytext] not checked")
diary << "Ban database connection failure. Key [ckeytext] not checked"
return
diff --git a/code/modules/admin/admin_ranks.dm b/code/modules/admin/admin_ranks.dm
index 4032554165a..b4816d87eab 100644
--- a/code/modules/admin/admin_ranks.dm
+++ b/code/modules/admin/admin_ranks.dm
@@ -127,8 +127,7 @@ var/list/admin_ranks = list() //list of all admin_rank datums
previous_rights = R.rights
else
- establish_db_connection()
- if(!dbcon.IsConnected())
+ if(!dbcon.Connect())
log_world("Failed to connect to database in load_admin_ranks(). Reverting to legacy system.")
diary << "Failed to connect to database in load_admin_ranks(). Reverting to legacy system."
config.admin_legacy_system = 1
@@ -202,8 +201,7 @@ var/list/admin_ranks = list() //list of all admin_rank datums
world.SetConfig("APP/admin", ckey, "role=admin")
D.associate(directory[ckey]) //find the client for a ckey if they are connected and associate them with the new admin datum
else
- establish_db_connection()
- if(!dbcon.IsConnected())
+ if(!dbcon.Connect())
log_world("Failed to connect to database in load_admins(). Reverting to legacy system.")
diary << "Failed to connect to database in load_admins(). Reverting to legacy system."
config.admin_legacy_system = 1
@@ -375,8 +373,7 @@ var/list/admin_ranks = list() //list of all admin_rank datums
edit_admin_permissions()
/datum/admins/proc/updateranktodb(ckey,newrank)
- establish_db_connection()
- if (!dbcon.IsConnected())
+ if(!dbcon.Connect())
return
var/sql_ckey = sanitizeSQL(ckey)
var/sql_admin_rank = sanitizeSQL(newrank)
diff --git a/code/modules/admin/ipintel.dm b/code/modules/admin/ipintel.dm
index af7296311f7..d6c02ee1e59 100644
--- a/code/modules/admin/ipintel.dm
+++ b/code/modules/admin/ipintel.dm
@@ -33,7 +33,7 @@
cachedintel.cache = TRUE
return cachedintel
- if (establish_db_connection())
+ if(dbcon.Connect())
var/DBQuery/query = dbcon.NewQuery({"
SELECT date, intel, TIMESTAMPDIFF(MINUTE,date,NOW())
FROM [format_table_name("ipintel")]
@@ -61,7 +61,7 @@
res.intel = ip_intel_query(ip)
if (updatecache && res.intel >= 0)
SSipintel.cache[ip] = res
- if (establish_db_connection())
+ if(dbcon.Connect())
var/DBQuery/query = dbcon.NewQuery("INSERT INTO [format_table_name("ipintel")] (ip, intel) VALUES (INET_ATON('[ip]'), [res.intel]) ON DUPLICATE KEY UPDATE intel = VALUES(intel), date = NOW()")
query.Execute()
return
diff --git a/code/modules/admin/permissionverbs/permissionedit.dm b/code/modules/admin/permissionverbs/permissionedit.dm
index 63fe0ee3149..89a0a5d703e 100644
--- a/code/modules/admin/permissionverbs/permissionedit.dm
+++ b/code/modules/admin/permissionverbs/permissionedit.dm
@@ -60,9 +60,7 @@
if (!check_rights(R_PERMISSIONS))
return
- establish_db_connection()
-
- if(!dbcon.IsConnected())
+ if(!dbcon.Connect())
usr << "Failed to establish database connection."
return
@@ -109,8 +107,7 @@
if(check_rights(R_PERMISSIONS))
return
- establish_db_connection()
- if(!dbcon.IsConnected())
+ if(!dbcon.Connect())
usr << "Failed to establish database connection."
return
diff --git a/code/modules/admin/verbs/reestablish_db_connection.dm b/code/modules/admin/verbs/reestablish_db_connection.dm
index 146b8481a19..d80ad68c8d0 100644
--- a/code/modules/admin/verbs/reestablish_db_connection.dm
+++ b/code/modules/admin/verbs/reestablish_db_connection.dm
@@ -15,7 +15,6 @@
return
dbcon.Disconnect()
- failed_db_connections = 0
log_admin("[key_name(usr)] has forced the database to disconnect")
message_admins("[key_name_admin(usr)] has forced the database to disconnect!")
feedback_add_details("admin_verb","FRDB") //If you are copy-pasting this, ensure the 2nd parameter is unique to the new proc!
@@ -24,8 +23,8 @@
message_admins("[key_name_admin(usr)] is attempting to re-established the DB Connection")
feedback_add_details("admin_verb","RDB") //If you are copy-pasting this, ensure the 2nd parameter is unique to the new proc!
- failed_db_connections = 0
- if (!establish_db_connection())
+ dbcon.failed_connections = 0
+ if(!dbcon.Connect())
message_admins("Database connection failed: " + dbcon.ErrorMsg())
else
message_admins("Database connection re-established")
\ No newline at end of file
diff --git a/code/modules/client/client_procs.dm b/code/modules/client/client_procs.dm
index e333ffe225e..b7984a7fe4c 100644
--- a/code/modules/client/client_procs.dm
+++ b/code/modules/client/client_procs.dm
@@ -325,8 +325,7 @@ var/next_external_rsc = 0
if (IsGuestKey(src.key))
return
- establish_db_connection()
- if(!dbcon.IsConnected())
+ if(!dbcon.Connect())
return
var/sql_ckey = sanitizeSQL(src.ckey)
@@ -347,8 +346,7 @@ var/next_external_rsc = 0
if (IsGuestKey(src.key))
return
- establish_db_connection()
- if (!dbcon.IsConnected())
+ if (!dbcon.Connect())
return
var/sql_ckey = sanitizeSQL(ckey)
diff --git a/code/modules/library/lib_machines.dm b/code/modules/library/lib_machines.dm
index e8ffdbe6368..5e628b6c952 100644
--- a/code/modules/library/lib_machines.dm
+++ b/code/modules/library/lib_machines.dm
@@ -43,8 +43,7 @@
dat += "Filter by Author: [author]
"
dat += "\[Start Search\]
"
if(1)
- establish_db_connection()
- if(!dbcon.IsConnected())
+ if (!dbcon.Connect())
dat += "ERROR: Unable to contact External Archive. Please contact your system administrator for assistance.
"
else if(!SQLquery)
dat += "ERROR: Malformed search request. Please contact your system administrator for assistance.
"
@@ -135,8 +134,7 @@ var/global/list/datum/cachedbook/cachedbooks // List of our cached book datums
/proc/load_library_db_to_cache()
if(cachedbooks)
return
- establish_db_connection()
- if(!dbcon.IsConnected())
+ if(!dbcon.Connect())
return
cachedbooks = list()
var/DBQuery/query = dbcon.NewQuery("SELECT id, author, title, category FROM [format_table_name("library")] WHERE isnull(deleted)")
@@ -408,8 +406,7 @@ var/global/list/datum/cachedbook/cachedbooks // List of our cached book datums
if(scanner.cache)
var/choice = input("Are you certain you wish to upload this title to the Archive?") in list("Confirm", "Abort")
if(choice == "Confirm")
- establish_db_connection()
- if(!dbcon.IsConnected())
+ if (!dbcon.Connect())
alert("Connection to Archive has been severed. Aborting.")
else
@@ -446,8 +443,7 @@ var/global/list/datum/cachedbook/cachedbooks // List of our cached book datums
if(href_list["targetid"])
var/sqlid = sanitizeSQL(href_list["targetid"])
- establish_db_connection()
- if(!dbcon.IsConnected())
+ if (!dbcon.Connect())
alert("Connection to Archive has been severed. Aborting.")
if(cooldown > world.time)
say("Printer unavailable. Please allow a short time before attempting to print.")
diff --git a/code/modules/library/random_books.dm b/code/modules/library/random_books.dm
index 1d5a3c3df6a..4685a3f2893 100644
--- a/code/modules/library/random_books.dm
+++ b/code/modules/library/random_books.dm
@@ -34,7 +34,7 @@
. = list()
if(!isnum(amount) || amount<1)
return
- if(!establish_db_connection())
+ if (!dbcon.Connect())
if(fail_loud || prob(5))
var/obj/item/weapon/paper/P = new(location)
P.info = "There once was a book from Nantucket
But the database failed us, so f*$! it.
I tried to be good to you
Now this is an I.O.U
If you're feeling entitled, well, stuff it!
~"
diff --git a/code/modules/mob/new_player/new_player.dm b/code/modules/mob/new_player/new_player.dm
index 35c7030aded..e03ad3649e3 100644
--- a/code/modules/mob/new_player/new_player.dm
+++ b/code/modules/mob/new_player/new_player.dm
@@ -40,9 +40,7 @@
output += "