cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-07-16 10:35:41 +01:00
Code Issues Packages Projects Releases Wiki Activity

Adds a unit test that makes sure subsystem flags make sense (#96022)

Browse Source 
## About The Pull Request

There's a few of these that conflict, mostly relating to timing. This
conflicting won't actually break anything but it does muddy "what is
this doing" somewhat and it's good to be clear so here we go

## Why It's Good For The Game

Makes the MC very slightly harder to confuse yourself with
This commit is contained in:
LemonInTheDark
2026-05-11 08:20:24 -07:00
committed by GitHub
parent f1a2ab4f76
commit 2dfbf0b81a
5 changed files with 32 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/unit_tests/_unit_tests.dm
+1
View File
@@ -327,6 +327,7 @@
#include "strippable.dm"
#include "stuns.dm"
#include "style_hotswapping.dm"
#include "subsystem_flags.dm"
#include "subsystem_init.dm"
#include "suit_sensor.dm"
#include "suit_storage_icons.dm"
code/modules/unit_tests/subsystem_flags.dm
+12
View File
@@ -0,0 +1,12 @@
// Ensures subystem flags are set in a coherent way
/datum/unit_test/subsystem_flags
/datum/unit_test/subsystem_flags/Run()
for(var/datum/controller/subsystem/sub_lad as anything in subtypesof(/datum/controller/subsystem))
if((sub_lad::ss_flags & (SS_TICKER | SS_KEEP_TIMING)) == (SS_TICKER | SS_KEEP_TIMING))
var/list/matching = get_matching_bitflags("ss_flags", sub_lad::ss_flags)
TEST_FAIL("[sub_lad] {[matching.Join(" | ")]} had both SS_TICKER and SEE_KEEP_TIMING set, this is redundant! You should likely remove SS_KEEP_TIMING.")
if((sub_lad::ss_flags & (SS_POST_FIRE_TIMING | SS_KEEP_TIMING)) == (SS_POST_FIRE_TIMING | SS_KEEP_TIMING))
var/list/matching = get_matching_bitflags("ss_flags", sub_lad::ss_flags)
TEST_FAIL("[sub_lad] {[matching.Join(" | ")]} had both SS_POST_FIRE_TIMING and SEE_KEEP_TIMING set, this is redundant! You should likely remove SS_KEEP_TIMING as SS_POST_FIRE_TIMING overrides it.")