From 2e968e82cc75018d0fcabea55a949ea039f7d10f Mon Sep 17 00:00:00 2001 From: SkyratBot <59378654+SkyratBot@users.noreply.github.com> Date: Sun, 18 Jun 2023 15:23:52 +0200 Subject: [PATCH] [MIRROR] Hidden nodes no longer become visible when copying them to another Techweb [MDB IGNORE] (#21775) * Hidden nodes no longer become visible when copying them to another Techweb (#75969) ## About The Pull Request Copying techwebs did not take into account whether available/researched/visible nodes were hidden in the techweb being copied from, so copying a base techweb to another would reveal all the bepis tech modules that are available but hidden. ## Why It's Good For The Game Pretty big cheat. Although you can't print disks any more there are Technology Disks lying around in science in most stations, so this still exploitable. ## Changelog :cl: fix: copying nodes from a techweb to another no longer reveals hidden nodes /:cl: * Hidden nodes no longer become visible when copying them to another Techweb --------- Co-authored-by: A miscellaneous Fern <80640114+FernandoJ8@users.noreply.github.com> --- code/modules/research/techweb/_techweb.dm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/modules/research/techweb/_techweb.dm b/code/modules/research/techweb/_techweb.dm index a4be5367abb..1ffae0a48dd 100644 --- a/code/modules/research/techweb/_techweb.dm +++ b/code/modules/research/techweb/_techweb.dm @@ -146,7 +146,7 @@ /datum/techweb/proc/copy_research_to(datum/techweb/receiver) //Adds any missing research to theirs. for(var/i in receiver.hidden_nodes) CHECK_TICK - if(available_nodes[i] || researched_nodes[i] || visible_nodes[i]) + if(get_available_nodes()[i] || get_researched_nodes()[i] || get_visible_nodes()[i]) receiver.hidden_nodes -= i //We can see it so let them see it too. for(var/i in researched_nodes) CHECK_TICK