Fix Last Command Member Cryo Announcement (#5174)

mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-22 12:41:09 +01:00

## About The Pull Request

Properly marks BA, NT Rep, and Blueshield as members of command within
the job flags. (when other parts of the code already consider them as
'command', e.g. the biscuit handout)

## Why It's Good For The Game

Resolves issue:
https://github.com/Bubberstation/Bubberstation/issues/5070

## Proof Of Testing

<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->
<details>
<summary>Screenshots/Videos</summary>

<img width="712" height="325" alt="image"
src="https://github.com/user-attachments/assets/8db7a5e6-96cd-49ee-8e42-426082a8f1ea"
/>

^ The manifest after the RD has cryo'd (Note lack of RD, which is
triggering the variable in the next screenshot), note that the count is
important here.


<img width="380" height="263" alt="image"
src="https://github.com/user-attachments/assets/e5157ce4-5b31-4ae9-a5a0-75e252232c31"
/>

^ The command member count, as the RD is entering cryo. 

Note: Before this fix, the count for this exact setup was `8` as it was
not counting the BA, NT Rep, and Blueshield.

This means that now on lowpop shifts where a BA would sign up, then a
member of command joining and then BA cryo'ing will now have the proper
count and will not fire off a 'last member of command has cryo'd
message'



</details>

## Changelog

🆑
fix: Fix last member of command has cryo'd announcement when there are
still member's of command on board.
/🆑

---------

Co-authored-by: LT3 <83487515+lessthnthree@users.noreply.github.com>

This commit is contained in:

BingusTheClown

2026-01-26 11:42:07 -08:00

committed by

GitHub

co-authored by

LT3

parent 382217adc9

commit 2e98eef84b

3 changed files with 4 additions and 3 deletions

code/modules/jobs/job_types/bridge_assistant.dm

+2 -1

View File

@@ -32,7 +32,8 @@
 	)
 	rpg_title = "Royal Guard"
 	allow_bureaucratic_error = FALSE
 	job_flags = STATION_JOB_FLAGS | JOB_ANTAG_BLACKLISTED | JOB_CANNOT_OPEN_SLOTS
 	// BUBBER EDIT - Previous: job_flags = STATION_JOB_FLAGS | JOB_ANTAG_BLACKLISTED | JOB_CANNOT_OPEN_SLOTS
 	job_flags = STATION_JOB_FLAGS | JOB_ANTAG_BLACKLISTED | HEAD_OF_STAFF_JOB_FLAGS
 	human_authority = JOB_AUTHORITY_NON_HUMANS_ALLOWED
 /obj/effect/landmark/start/bridge_assistant