From 2ec99420a3162d79eec2f13669dd6a17ec21cbf2 Mon Sep 17 00:00:00 2001 From: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Date: Sun, 30 Nov 2025 14:37:34 -0500 Subject: [PATCH] Adds a mapping log to plumbing destroying ducts (#94159) ## About The Pull Request image This will trigger if you create a plumbing machine on top of a duct, but we're only caring for roundstart here? I can't use banned neighbors because I don't want to add a list that must be constantly maintained for every machine that uses the component. ## Why It's Good For The Game Prior to this PR, this is the only error you'd get about this occuring image Very undescriptive and I had to go through every single duct on a map to figure out what was being deleted, turns out it was a single duct being mapped on top of a toilet. --- code/datums/components/plumbing/_plumbing.dm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/code/datums/components/plumbing/_plumbing.dm b/code/datums/components/plumbing/_plumbing.dm index d2414cc5af0..b6319116b6c 100644 --- a/code/datums/components/plumbing/_plumbing.dm +++ b/code/datums/components/plumbing/_plumbing.dm @@ -244,6 +244,8 @@ // Machines disable when they get moved for(var/obj/machinery/duct/duct in parent_movable.loc) if(duct.anchored && (duct.duct_layer & ducting_layer)) + log_mapping("[duct.name] was found at [AREACOORD(parent_movable)] spawning on top of [parent_movable.name], \ + which should not occur as it takes ducts itself!") duct.disconnect_duct() if(demand_connects)