mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-23 13:10:02 +01:00
Speed up Mapper testing with a prefix "maptest_" in VSCode (#93238)
## About The Pull Request One of the development hell cycles with mapping is how long it takes to fix quality or run issues with maps. By adding a prefix called "maptest_" to some of the unit tests it allows mappers to only target some tests instead of the usual 350+ tests to run each time or trying to trigger them individually and faffing. This does not rename the unit test files themselves to preserve history but just the "/datum/unit_test/" in each file. This does not break the current CI or obstruct other tests - A few other map files that call these tests specifically have been edited to point at the new datum name. This assumes you are using the TG testing extension to do this. | All Tests | maptest_ | |--------|--------| | <img width="426" height="106" alt="image" src="https://github.com/user-attachments/assets/d1d6f81e-16bd-473a-88da-e8b56f8bd3d0" /> | <img width="434" height="96" alt="image" src="https://github.com/user-attachments/assets/ea1c47fe-a6ce-40c6-b2cb-65b9c8e94a29" /> | | <img width="360" height="886" alt="image" src="https://github.com/user-attachments/assets/65bcd774-79ad-432e-8211-c67fb9d3e443" /> | <img width="370" height="833" alt="Screenshot 2025-10-01 204609" src="https://github.com/user-attachments/assets/ad360796-5698-42fd-bd2e-51de1a02ab87" /> | ## Why It's Good For The Game - Should make it easier for mappers to test locally, saving CI/Github resource for TG - Mappers can now test their work 56% faster ## Changelog 🆑 code: Mappers can now run just mapping unit tests - Should be 56% faster - Should have no player impact /🆑 Co-authored-by: loganuk <falseemail@aol.com>
This commit is contained in:
@@ -5,14 +5,14 @@
|
||||
* - Add the typepath(s) to setup_expected_types
|
||||
* - In the type's initialize, REGISTER_REQUIRED_MAP_ITEM() a minimum and maximum
|
||||
*/
|
||||
/datum/unit_test/required_map_items
|
||||
/datum/unit_test/maptest_required_map_items
|
||||
/// A list of all typepaths that we expect to be in the required items list
|
||||
var/list/expected_types = list()
|
||||
|
||||
/// Used to fill the expected types list with all the types we look for on the map.
|
||||
/// This list will just be full of typepaths that we expect.
|
||||
/// More detailed information about each item (mainly, how much of each should exist) is set on a per item basis
|
||||
/datum/unit_test/required_map_items/proc/setup_expected_types()
|
||||
/datum/unit_test/maptest_required_map_items/proc/setup_expected_types()
|
||||
expected_types += subtypesof(/obj/item/stamp/head)
|
||||
expected_types += subtypesof(/obj/machinery/modular_computer/preset/cargochat)
|
||||
|
||||
@@ -23,7 +23,7 @@
|
||||
expected_types += /obj/machinery/drone_dispenser
|
||||
expected_types += /obj/item/piggy_bank/vault
|
||||
|
||||
/datum/unit_test/required_map_items/Run()
|
||||
/datum/unit_test/maptest_required_map_items/Run()
|
||||
setup_expected_types()
|
||||
|
||||
var/list/required_map_items = GLOB.required_map_items.Copy()
|
||||
|
||||
Reference in New Issue
Block a user