[MIRROR] [s] Audits object say() uses to make handling text more safe (#7927)

* [s] Audits object say() uses to make handling text more safe (#61147)

Made all say()s deal with encoding, audited all uses of say() to prevent double encoding or like, manually inserting span().
I left some stuff without sanitize that only draws from the code, since it's hell to clean up otherwise. That
and I let admins do whatever the fuck they want

* [s] Audits object say() uses to make handling text more safe

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
This commit is contained in:
SkyratBot
2021-09-02 15:57:10 -04:00
committed by GitHub
co-authored by LemonInTheDark
parent f208462312
commit 302798dbb7
15 changed files with 31 additions and 21 deletions
+4 -3
View File
@@ -231,6 +231,7 @@
locked = TRUE
use_power = NO_POWER_USE
resistance_flags = INDESTRUCTIBLE | LAVA_PROOF | FIRE_PROOF | UNACIDABLE | ACID_PROOF
speech_span = SPAN_ROBOT
var/threshold = 500
var/static/list/approved_passengers = list()
var/static/list/check_times = list()
@@ -245,7 +246,7 @@
var/obj/vehicle/vehicle = mover
for(var/mob/living/rat in vehicle.occupants)
if(!(rat in approved_passengers))
say(span_robot("Stowaway detected. Please exit the vehicle first."))
say("Stowaway detected. Please exit the vehicle first.")
return FALSE
return TRUE
if(isitem(mover))
@@ -253,7 +254,7 @@
if(isstructure(mover))
var/obj/structure/struct = mover
for(var/mob/living/rat in struct.contents)
say(span_robot("Stowaway detected. Please exit the structure first."))
say("Stowaway detected. Please exit the structure first.")
return FALSE
return TRUE
@@ -378,7 +379,7 @@
AM.pulling = HC
payees[AM] -= payees[AM]
say(span_robot("Welcome to first class, [driver_holdout ? "[driver_holdout]" : "[AM]" ]![change ? " Here is your change." : ""]"))
say("Welcome to first class, [driver_holdout ? "[driver_holdout]" : "[AM]" ]![change ? " Here is your change." : ""]")
approved_passengers |= AM
if(vehicle)
approved_passengers |= vehicle