From 35bd600bf91da331ee4a5848aa624bf71293b585 Mon Sep 17 00:00:00 2001
From: RikuTheKiller <88713943+RikuTheKiller@users.noreply.github.com>
Date: Thu, 30 Mar 2023 11:39:15 +0300
Subject: [PATCH] Fixes suffocation damage and healing for reagents (#74292)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

This fixes a hidden side effect of the "refactor" in #73147 that
actually caused ALL existing suffocation damage dealing/healing
chemicals to not work on species that breathe gases other than oxygen.

This is also good for future code since if you want a chemical to not
affect a specific species or such, you should explicitly define that, it
shouldn't be implicitly done for you in the background with 0
implication.

Also reverts #74247 since it's no longer needed.

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game

First off, the change was unintended. It was intended to be a refactor.

Second, the change is unfun and isn't explained anywhere. It isn't very
fun to sit on the floor in medbay while even the most experienced
doctors can't figure out why the strongest suffocation healing chemicals
in the game aren't working. Cue this on repeat for 30 minutes. I've
personally experienced this like 10 times now and even I didn't know why
it was happening.

Even if you know the change exists, it's still extremely convoluted to
get around. You have to do CPR on a plasmaman at the speed of an average
cheetah or abuse the brute/burn revival method.

<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

:cl:
fix: Suffocation-handling reagents work on all species once more.
spellcheck: Added a previous tip for handling plasmaman suffocation back
into the game.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
---
 code/modules/reagents/chemistry/reagents.dm | 2 +-
 strings/tips.txt                            | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/code/modules/reagents/chemistry/reagents.dm b/code/modules/reagents/chemistry/reagents.dm
index cdf8080d4a7..f03cd699d2b 100644
--- a/code/modules/reagents/chemistry/reagents.dm
+++ b/code/modules/reagents/chemistry/reagents.dm
@@ -88,7 +88,7 @@ GLOBAL_LIST_INIT(name2reagent, build_name2reagent())
 	var/affected_biotype = MOB_ORGANIC
 	/// The affected respiration type, if the reagent damages/heals oxygen damage of an affected mob.
 	/// See "Mob bio-types flags" in /code/_DEFINES/mobs.dm
-	var/affected_respiration_type = RESPIRATION_OXYGEN
+	var/affected_respiration_type = ALL
 	/// The affected organtype, if the reagent damages/heals organ damage of an affected mob.
 	/// See "Organ defines for carbon mobs" in /code/_DEFINES/mobs.dm
 	var/affected_organtype = ORGAN_ORGANIC
diff --git a/strings/tips.txt b/strings/tips.txt
index 1f726b18a4f..0569c19c09a 100644
--- a/strings/tips.txt
+++ b/strings/tips.txt
@@ -51,7 +51,7 @@ As a Medical Doctor, corpses placed inside a freezer or morgue tray will have th
 As a Medical Doctor, corpses with the "...and their soul has departed" description no longer have a ghost attached to them and can't be revived.
 As a Medical Doctor, Critical Slash wounds are one of the most dangerous conditions someone can have. Apply gauze, epipens, sutures, cauteries, whatever you can, as soon as possible!
 As a Medical Doctor, Saline-Glucose not only acts as a temporary boost to a patient's blood level, it also speeds blood regeneration! Perfect for drained patients!
-As a Medical Doctor, treating plasmamen is not impossible! Showers stop them from burning alive. You can even perform surgery on them by doing the procedure on a roller bed under a shower. Salbutamol and convermol do NOT heal their oxyloss damage.
+As a Medical Doctor, treating plasmamen is not impossible! Salbutamol stops them from suffocating and showers stop them from burning alive. You can even perform surgery on them by doing the procedure on a roller bed under a shower. Salbutamol and convermol do NOT heal their oxyloss damage.
 As a Medical Doctor, you can attempt to drain blood from a husk with a syringe to determine the cause. If you can extract blood, it was caused by extreme temperatures or lasers, if there is no blood to extract, you have confirmed the presence of changelings.
 As a Medical Doctor, you can deal with patients who have absurd amounts of wounds by putting them in cryo. This will slowly treat all of their wounds simultaneously, but is much slower than direct treatment.
 As a Medical Doctor, you can extract implants by holding an empty implant case in your offhand while performing the extraction step.