From 08e7911f5707a49db2c1afb881c9b3ace9a5142d Mon Sep 17 00:00:00 2001 From: Kraseo Date: Sun, 8 Feb 2015 13:27:55 +0100 Subject: [PATCH 1/4] fixes a bunch of bugs --- code/game/machinery/vending.dm | 14 ++++++++++---- .../objects/structures/crates_lockers/closets.dm | 4 ++-- code/modules/admin/verbs/one_click_antag.dm | 13 +++++++------ code/modules/paperwork/filingcabinet.dm | 5 +++++ 4 files changed, 24 insertions(+), 12 deletions(-) diff --git a/code/game/machinery/vending.dm b/code/game/machinery/vending.dm index 3d1ee4fe829..875efbab113 100644 --- a/code/game/machinery/vending.dm +++ b/code/game/machinery/vending.dm @@ -768,8 +768,11 @@ products = list(/obj/item/weapon/reagent_containers/syringe = 12,/obj/item/stack/medical/gauze = 8,/obj/item/weapon/reagent_containers/pill/patch/styptic = 10, /obj/item/weapon/reagent_containers/pill/patch/silver_sulf = 10,/obj/item/weapon/reagent_containers/glass/bottle/charcoal = 4, /obj/item/weapon/reagent_containers/glass/bottle/epinephrine = 4,/obj/item/weapon/reagent_containers/glass/bottle/morphine = 4, - /obj/item/weapon/reagent_containers/glass/bottle/diphenhydramine = 4,/obj/item/weapon/reagent_containers/glass/bottle/potass_iodide = 3, /obj/item/weapon/reagent_containers/glass/bottle/salglu_solution = 5,/obj/item/weapon/reagent_containers/glass/bottle/atropine = 3,/obj/item/weapon/reagent_containers/syringe/antiviral = 6,/obj/item/weapon/reagent_containers/syringe/calomel = 10,/obj/item/weapon/reagent_containers/pill/salbutamol = 10,/obj/item/weapon/reagent_containers/pill/mannitol = 10,/obj/item/weapon/reagent_containers/pill/mutadone = 5,/obj/item/device/healthanalyzer = 4, /obj/item/device/sensor_device = 2) - contraband = list(/obj/item/weapon/reagent_containers/glass/bottle/toxin = 3,/obj/item/weapon/reagent_containers/pill/tox = 3,/obj/item/weapon/reagent_containers/pill/morphine = 4,/obj/item/weapon/reagent_containers/pill/charcoal = 6) + /obj/item/weapon/reagent_containers/glass/bottle/diphenhydramine = 4,/obj/item/weapon/reagent_containers/glass/bottle/potass_iodide = 3, + /obj/item/weapon/reagent_containers/glass/bottle/salglu_solution = 5,/obj/item/weapon/reagent_containers/glass/bottle/atropine = 3,/obj/item/weapon/reagent_containers/syringe/antiviral = 6, + /obj/item/weapon/reagent_containers/syringe/calomel = 10,/obj/item/weapon/reagent_containers/pill/salbutamol = 10,/obj/item/weapon/reagent_containers/pill/mannitol = 10, + /obj/item/weapon/reagent_containers/pill/mutadone = 5,/obj/item/device/healthanalyzer = 4, /obj/item/device/sensor_device = 2,/obj/item/weapon/reagent_containers/glass/bottle/toxin = 3) + contraband = list(/obj/item/weapon/reagent_containers/pill/tox = 3,/obj/item/weapon/reagent_containers/pill/morphine = 4,/obj/item/weapon/reagent_containers/pill/charcoal = 6) //This one's from bay12 @@ -790,8 +793,11 @@ products = list(/obj/item/weapon/reagent_containers/syringe = 6,/obj/item/weapon/reagent_containers/pill/patch/styptic = 5, /obj/item/weapon/reagent_containers/pill/patch/silver_sulf = 5,/obj/item/weapon/reagent_containers/glass/bottle/charcoal = 2, /obj/item/weapon/reagent_containers/glass/bottle/epinephrine = 2,/obj/item/weapon/reagent_containers/glass/bottle/morphine = 2, - /obj/item/weapon/reagent_containers/glass/bottle/diphenhydramine = 2,/obj/item/weapon/reagent_containers/glass/bottle/potass_iodide = 2, /obj/item/weapon/reagent_containers/glass/bottle/salglu_solution = 3,/obj/item/weapon/reagent_containers/glass/bottle/atropine = 2,/obj/item/weapon/reagent_containers/syringe/antiviral = 3,/obj/item/weapon/reagent_containers/syringe/calomel = 5,/obj/item/weapon/reagent_containers/pill/salbutamol = 5,/obj/item/weapon/reagent_containers/pill/mannitol = 5,/obj/item/weapon/reagent_containers/pill/mutadone = 3,/obj/item/device/healthanalyzer = 2, /obj/item/device/sensor_device = 1) - contraband = list(/obj/item/weapon/reagent_containers/glass/bottle/toxin = 2,/obj/item/weapon/reagent_containers/pill/tox = 2,/obj/item/weapon/reagent_containers/pill/morphine = 2,/obj/item/weapon/reagent_containers/pill/charcoal = 3) + /obj/item/weapon/reagent_containers/glass/bottle/diphenhydramine = 2,/obj/item/weapon/reagent_containers/glass/bottle/potass_iodide = 2, + /obj/item/weapon/reagent_containers/glass/bottle/salglu_solution = 3,/obj/item/weapon/reagent_containers/glass/bottle/atropine = 2,/obj/item/weapon/reagent_containers/syringe/antiviral = 3, + /obj/item/weapon/reagent_containers/syringe/calomel = 5,/obj/item/weapon/reagent_containers/pill/salbutamol = 5,/obj/item/weapon/reagent_containers/pill/mannitol = 5, + /obj/item/weapon/reagent_containers/pill/mutadone = 3,/obj/item/device/healthanalyzer = 2, /obj/item/device/sensor_device = 1,/obj/item/weapon/reagent_containers/glass/bottle/toxin = 2) + contraband = list(/obj/item/weapon/reagent_containers/pill/tox = 2,/obj/item/weapon/reagent_containers/pill/morphine = 2,/obj/item/weapon/reagent_containers/pill/charcoal = 3) /obj/machinery/vending/security name = "\improper SecTech" diff --git a/code/game/objects/structures/crates_lockers/closets.dm b/code/game/objects/structures/crates_lockers/closets.dm index 54ed6539c1b..464400eb1f4 100644 --- a/code/game/objects/structures/crates_lockers/closets.dm +++ b/code/game/objects/structures/crates_lockers/closets.dm @@ -126,10 +126,10 @@ return src.close() return src.open() -// this should probably use dump_contents() /obj/structure/closet/ex_act(severity, target) - contents_explosion(severity, target) + dump_contents() open() + qdel(src) ..() /obj/structure/closet/bullet_act(var/obj/item/projectile/Proj) diff --git a/code/modules/admin/verbs/one_click_antag.dm b/code/modules/admin/verbs/one_click_antag.dm index 46ace545763..af7162d22cd 100644 --- a/code/modules/admin/verbs/one_click_antag.dm +++ b/code/modules/admin/verbs/one_click_antag.dm @@ -465,20 +465,21 @@ client/proc/one_click_antag() //Spawn and equip the officer var/mob/living/carbon/human/ERTOperative = new(spawnloc) + var/list/ERTOpname = commando_names chosen_candidate.client.prefs.copy_to(ERTOperative) ready_dna(ERTOperative) switch(numagents) if(1) - ERTOperative.real_name = "Commander [pick(ERTOperative.real_name)]" + ERTOperative.real_name = "Commander [pick(ERTOpname)]" equip_emergencyresponsesquad(ERTOperative, "commander") if(2 || 5) - ERTOperative.real_name = "Officer [pick(ERTOperative.real_name)]" + ERTOperative.real_name = "Security Officer [pick(ERTOpname)]" equip_emergencyresponsesquad(ERTOperative, "sec") if(3 || 6) - ERTOperative.real_name = "Officer [pick(ERTOperative.real_name)]" + ERTOperative.real_name = "Medical Officer [pick(ERTOpname)]" equip_emergencyresponsesquad(ERTOperative, "med") if(4 || 7) - ERTOperative.real_name = "Officer [pick(ERTOperative.real_name)]" + ERTOperative.real_name = "Engineer [pick(ERTOpname)]" equip_emergencyresponsesquad(ERTOperative, "eng") ERTOperative.key = chosen_candidate.key ERTOperative.mind.assigned_role = "ERT" @@ -493,7 +494,7 @@ client/proc/one_click_antag() ERTOperative.mind.objectives += missionobj //Greet the commando - ERTOperative << "You are the [numagents==1?"Emergency Response Team Commander":"Emergency Response Officer"]." + ERTOperative << "You are [numagents==1?"the Emergency Response Team Commander":"an Emergency Response Officer"]." var/missiondesc = "Your squad is being sent on a mission to [station_name()] by Nanotrasen's Security Division." if(numagents == 1) //If Squad Leader missiondesc += " Lead your squad to ensure the completion of the mission. Avoid civilian casualites when possible. Board the shuttle when your team is ready." @@ -505,7 +506,7 @@ client/proc/one_click_antag() //Logging and cleanup if(numagents == 1) message_admins("The emergency response team has spawned with the mission: [mission].") - log_game("[key_name(ERTOperative)] has been selected as a Emergency Response Officer") + log_game("[key_name(ERTOperative)] has been selected as an Emergency Response Officer") spawnpoints -= spawnloc numagents-- diff --git a/code/modules/paperwork/filingcabinet.dm b/code/modules/paperwork/filingcabinet.dm index 44bc38e6e04..ccc56ce4e4c 100644 --- a/code/modules/paperwork/filingcabinet.dm +++ b/code/modules/paperwork/filingcabinet.dm @@ -35,6 +35,11 @@ if(istype(I, /obj/item/weapon/paper) || istype(I, /obj/item/weapon/folder) || istype(I, /obj/item/weapon/photo)) I.loc = src +/obj/structure/filingcabinet/ex_act(severity, target) + for(var/obj/item/I in src) + I.loc = src.loc + qdel(src) + ..() /obj/structure/filingcabinet/attackby(obj/item/P, mob/user) if(istype(P, /obj/item/weapon/paper) || istype(P, /obj/item/weapon/folder) || istype(P, /obj/item/weapon/photo) || istype(P, /obj/item/documents)) From 4e18859e7becc76b3dba39b83c7f43f134df6464 Mon Sep 17 00:00:00 2001 From: Kraseo Date: Sun, 8 Feb 2015 15:13:04 +0100 Subject: [PATCH 2/4] fixes lockers/bodybags/etc. shielding you from explosions. whoops! --- code/game/objects/structures/crates_lockers/closets.dm | 1 + 1 file changed, 1 insertion(+) diff --git a/code/game/objects/structures/crates_lockers/closets.dm b/code/game/objects/structures/crates_lockers/closets.dm index 464400eb1f4..0abb895d941 100644 --- a/code/game/objects/structures/crates_lockers/closets.dm +++ b/code/game/objects/structures/crates_lockers/closets.dm @@ -127,6 +127,7 @@ return src.open() /obj/structure/closet/ex_act(severity, target) + contents_explosion(severity, target) dump_contents() open() qdel(src) From 91c1a54abd6192ea26f146e4885751bee3af4726 Mon Sep 17 00:00:00 2001 From: Kraseo Date: Sun, 8 Feb 2015 23:33:33 +0100 Subject: [PATCH 3/4] closes the open() --- code/game/objects/structures/crates_lockers/closets.dm | 1 - 1 file changed, 1 deletion(-) diff --git a/code/game/objects/structures/crates_lockers/closets.dm b/code/game/objects/structures/crates_lockers/closets.dm index 0abb895d941..10ba58741b0 100644 --- a/code/game/objects/structures/crates_lockers/closets.dm +++ b/code/game/objects/structures/crates_lockers/closets.dm @@ -129,7 +129,6 @@ /obj/structure/closet/ex_act(severity, target) contents_explosion(severity, target) dump_contents() - open() qdel(src) ..() From 80191947e21d5c998ac6bb0c4ee357ae8daff01b Mon Sep 17 00:00:00 2001 From: Kraseo Date: Mon, 9 Feb 2015 20:10:29 +0100 Subject: [PATCH 4/4] ERT now spawn with random names because cheri hates fun --- code/modules/admin/verbs/one_click_antag.dm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/code/modules/admin/verbs/one_click_antag.dm b/code/modules/admin/verbs/one_click_antag.dm index af7162d22cd..422b26ec36d 100644 --- a/code/modules/admin/verbs/one_click_antag.dm +++ b/code/modules/admin/verbs/one_click_antag.dm @@ -465,21 +465,21 @@ client/proc/one_click_antag() //Spawn and equip the officer var/mob/living/carbon/human/ERTOperative = new(spawnloc) - var/list/ERTOpname = commando_names + var/list/lastname = last_names chosen_candidate.client.prefs.copy_to(ERTOperative) ready_dna(ERTOperative) switch(numagents) if(1) - ERTOperative.real_name = "Commander [pick(ERTOpname)]" + ERTOperative.real_name = "Commander [pick(lastname)]" equip_emergencyresponsesquad(ERTOperative, "commander") if(2 || 5) - ERTOperative.real_name = "Security Officer [pick(ERTOpname)]" + ERTOperative.real_name = "Security Officer [pick(lastname)]" equip_emergencyresponsesquad(ERTOperative, "sec") if(3 || 6) - ERTOperative.real_name = "Medical Officer [pick(ERTOpname)]" + ERTOperative.real_name = "Medical Officer [pick(lastname)]" equip_emergencyresponsesquad(ERTOperative, "med") if(4 || 7) - ERTOperative.real_name = "Engineer [pick(ERTOpname)]" + ERTOperative.real_name = "Engineer [pick(lastname)]" equip_emergencyresponsesquad(ERTOperative, "eng") ERTOperative.key = chosen_candidate.key ERTOperative.mind.assigned_role = "ERT"