From 3b0bed4b03352d19e97b90422017ed52888b9c99 Mon Sep 17 00:00:00 2001
From: SkyratBot <59378654+SkyratBot@users.noreply.github.com>
Date: Mon, 25 Apr 2022 15:29:21 +0200
Subject: [PATCH] [MIRROR] fixes problems with access helpers [MDB IGNORE]
 (#13099)

* fixes problems with access helpers (#66456)

    Makes Library access helper use Library access instead of Theatre
    Adds a Theatre access helper for Theatre
    Adds an Engine equip access helper for Engine equip (SMES/Grav gen, in the case of Pubby, aka the whole reason I made this PR).
    Removes double crematoriums

It's nice when helpers work as they are supposed to, and if used in the future, will help our maps have less varediting. pretty cool.

* fixes problems with access helpers

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
---
 code/modules/mapping/access_helpers.dm | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/code/modules/mapping/access_helpers.dm b/code/modules/mapping/access_helpers.dm
index 30b96bf28b5..dec90bc1128 100644
--- a/code/modules/mapping/access_helpers.dm
+++ b/code/modules/mapping/access_helpers.dm
@@ -77,6 +77,11 @@
 	access_list += ACCESS_ENGINE
 	return access_list
 
+/obj/effect/mapping_helpers/airlock/access/any/engineering/engine_equipment/get_access()
+	var/list/access_list = ..()
+	access_list += ACCESS_ENGINE_EQUIP
+	return access_list
+
 /obj/effect/mapping_helpers/airlock/access/any/engineering/construction/get_access()
 	var/list/access_list = ..()
 	access_list += ACCESS_CONSTRUCTION
@@ -288,17 +293,12 @@
 	access_list += ACCESS_CREMATORIUM
 	return access_list
 
-/obj/effect/mapping_helpers/airlock/access/any/service/crematorium/get_access()
-	var/list/access_list = ..()
-	access_list += ACCESS_CREMATORIUM
-	return access_list
-
 /obj/effect/mapping_helpers/airlock/access/any/service/library/get_access()
 	var/list/access_list = ..()
 	access_list += ACCESS_LIBRARY
 	return access_list
 
-/obj/effect/mapping_helpers/airlock/access/any/service/library/get_access()
+/obj/effect/mapping_helpers/airlock/access/any/service/theatre/get_access()
 	var/list/access_list = ..()
 	access_list += ACCESS_THEATRE
 	return access_list
@@ -396,6 +396,11 @@
 	access_list += ACCESS_ENGINE
 	return access_list
 
+/obj/effect/mapping_helpers/airlock/access/all/engineering/engine_equipment/get_access()
+	var/list/access_list = ..()
+	access_list += ACCESS_ENGINE_EQUIP
+	return access_list
+
 /obj/effect/mapping_helpers/airlock/access/all/engineering/construction/get_access()
 	var/list/access_list = ..()
 	access_list += ACCESS_CONSTRUCTION
@@ -607,17 +612,12 @@
 	access_list += ACCESS_CREMATORIUM
 	return access_list
 
-/obj/effect/mapping_helpers/airlock/access/all/service/crematorium/get_access()
-	var/list/access_list = ..()
-	access_list += ACCESS_CREMATORIUM
-	return access_list
-
 /obj/effect/mapping_helpers/airlock/access/all/service/library/get_access()
 	var/list/access_list = ..()
 	access_list += ACCESS_LIBRARY
 	return access_list
 
-/obj/effect/mapping_helpers/airlock/access/all/service/library/get_access()
+/obj/effect/mapping_helpers/airlock/access/all/service/theatre/get_access()
 	var/list/access_list = ..()
 	access_list += ACCESS_THEATRE
 	return access_list