Converts some notify_ghosts args to bitflags, multilines all notify_ghosts calls (#79320)

## About The Pull Request

This helps clean up my favorite helper proc in the whole codebase,
`notify_ghosts()`.

The notify_suiciders, ignore_mapload, and flashwindow args are GONE.
They have been replaced with the notify_flags bitflag argument. This was
intended to make deadchat announcements a bitflag argument too, but
those got reverted right before I originally wanted to submit this PR.

The on-screen popup now shows the notification body when you hover it
with your mouse again. The format is now `[notify_ghosts message] --
[click action (orbit/jump/play)]`

Every single `notify_ghosts()` call has been changed to multiline format
and has been given trailing commas. Pretty!
## Why It's Good For The Game

Cleans up a proc that is very popular and going through a lot of changes
at the time.

Allows for further flexibility when this proc inevitably gets tweaked or
improved. 12 -> 10 args is an improvement, and it doesn't impact the
helper's flexibility at all.
## Changelog
🆑 Rhials
code: The notify_ghosts proc has been cleaned up. Please report any
abnormal changes in deadchat notification behavior.
qol: The on-screen deadchat popups now contain the notification blurb
when hovered with your mouse again.
/🆑
This commit is contained in:
Rhials
2023-11-05 15:26:50 -08:00
committed by GitHub
parent 4851087fc1
commit 3c7005a37c
56 changed files with 365 additions and 79 deletions
@@ -26,7 +26,13 @@
. = ..()
var/area/area = get_area(src)
if(area)
notify_ghosts("A drone shell has been created in \the [area.name].", source = src, action = NOTIFY_PLAY, flashwindow = FALSE, ignore_key = POLL_IGNORE_DRONE, notify_suiciders = FALSE)
notify_ghosts(
"A drone shell has been created in \the [area.name].",
source = src,
action = NOTIFY_PLAY,
notify_flags = (GHOST_NOTIFY_IGNORE_MAPLOAD),
ignore_key = POLL_IGNORE_DRONE,
)
/obj/effect/mob_spawn/ghost_role/drone/allow_spawn(mob/user, silent = FALSE)
var/client/user_client = user.client