mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-23 21:18:37 +01:00
Converts some notify_ghosts args to bitflags, multilines all notify_ghosts calls (#79320)
## About The Pull Request This helps clean up my favorite helper proc in the whole codebase, `notify_ghosts()`. The notify_suiciders, ignore_mapload, and flashwindow args are GONE. They have been replaced with the notify_flags bitflag argument. This was intended to make deadchat announcements a bitflag argument too, but those got reverted right before I originally wanted to submit this PR. The on-screen popup now shows the notification body when you hover it with your mouse again. The format is now `[notify_ghosts message] -- [click action (orbit/jump/play)]` Every single `notify_ghosts()` call has been changed to multiline format and has been given trailing commas. Pretty! ## Why It's Good For The Game Cleans up a proc that is very popular and going through a lot of changes at the time. Allows for further flexibility when this proc inevitably gets tweaked or improved. 12 -> 10 args is an improvement, and it doesn't impact the helper's flexibility at all. ## Changelog 🆑 Rhials code: The notify_ghosts proc has been cleaned up. Please report any abnormal changes in deadchat notification behavior. qol: The on-screen deadchat popups now contain the notification blurb when hovered with your mouse again. /🆑
This commit is contained in:
@@ -172,14 +172,14 @@
|
||||
"The battlecruiser has an object of interest: [our_candidate]!",
|
||||
source = our_candidate,
|
||||
action = NOTIFY_ORBIT,
|
||||
header = "Something's Interesting!"
|
||||
)
|
||||
header = "Something's Interesting!",
|
||||
)
|
||||
else
|
||||
notify_ghosts(
|
||||
"The battlecruiser has an object of interest: [spawner]!",
|
||||
source = spawner,
|
||||
action = NOTIFY_ORBIT,
|
||||
header="Something's Interesting!"
|
||||
)
|
||||
header="Something's Interesting!",
|
||||
)
|
||||
|
||||
priority_announce("Unidentified armed ship detected near the station.")
|
||||
|
||||
Reference in New Issue
Block a user