From 3e2e59d862908f1bd1c763ef2fb5bf7893e258fb Mon Sep 17 00:00:00 2001 From: SkyratBot <59378654+SkyratBot@users.noreply.github.com> Date: Mon, 21 Aug 2023 04:01:08 +0200 Subject: [PATCH] [MIRROR] Fixes beakers disappearing when switching in chem heater [MDB IGNORE] (#23229) * Fixes beakers disappearing when switching in chem heater (#77770) ## About The Pull Request Fixes #77762 The function to replace beakers in the Chem Heater unregistered the signal from the beaker after removing it, causing it to break and the beaker to disappear. This fixes that by unregistering the signal first. ## Why It's Good For The Game Beakers don't disappear when you try to swap them in the Chem Heater anymore. ## Changelog :cl: fix: fixed beakers disappearing when swapped in a chem heater /:cl: * Fixes beakers disappearing when switching in chem heater --------- Co-authored-by: Ical <86125936+Ical92@users.noreply.github.com> --- code/modules/reagents/chemistry/machinery/chem_heater.dm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/modules/reagents/chemistry/machinery/chem_heater.dm b/code/modules/reagents/chemistry/machinery/chem_heater.dm index 849052f2141..3716715a2d6 100644 --- a/code/modules/reagents/chemistry/machinery/chem_heater.dm +++ b/code/modules/reagents/chemistry/machinery/chem_heater.dm @@ -78,8 +78,8 @@ if(!user) return FALSE if(beaker) - try_put_in_hand(beaker, user) UnregisterSignal(beaker.reagents, COMSIG_REAGENTS_REACTION_STEP) + try_put_in_hand(beaker, user) beaker = null if(new_beaker) beaker = new_beaker