Merge pull request #20476 from ChangelingRain/takingbackanemptythreatmorethanyoucouldeverknowtakeitbackwithnoregretsiwasbetteroffwheniwasonyoursideandiwasholdingon

Removes the horrible anim() proc and a bunch of spawns

code/modules/mob/living/simple_animal/hostile/megafauna/bubblegum.dm

@@ -197,7 +197,7 @@ Difficulty: Hard
 	for(var/turf/J in getline(src,E))
 		if(!range)
 			break
-		PoolOrNew(/obj/effect/overlay/temp/bloodsplatter, list(previousturf, get_dir(previousturf, J)))
+		PoolOrNew(/obj/effect/overlay/temp/dir_setting/bloodsplatter, list(previousturf, get_dir(previousturf, J)))
 		if(!previousturf.CanAtmosPass(J))
 			break
 		playsound(J,'sound/effects/splat.ogg', 100, 1, -1)

code/modules/mob/mob_movement.dm

@@ -236,14 +236,12 @@
 				L.loc = locate(locx,locy,mobloc.z)
 				var/limit = 2//For only two trailing shadows.
 				for(var/turf/T in getline(mobloc, L.loc))
-					spawn(0)
-						anim(T,L,'icons/mob/mob.dmi',,"shadow",,L.dir)
+					PoolOrNew(/obj/effect/overlay/temp/dir_setting/ninja/shadow, list(T, L.dir))
 					limit--
 					if(limit<=0)
 						break
 			else
-				spawn(0)
-					anim(mobloc,mob,'icons/mob/mob.dmi',,"shadow",,L.dir)
+				PoolOrNew(/obj/effect/overlay/temp/dir_setting/ninja/shadow, list(mobloc, L.dir))
 				L.loc = get_step(L, direct)
 			L.setDir(direct)
 		if(3) //Incorporeal move, but blocked by holy-watered tiles and salt piles.

code/modules/mob/transform_procs.dm

@@ -41,14 +41,9 @@
 	cut_overlays()
 	invisibility = INVISIBILITY_MAXIMUM
 
-	var/atom/movable/overlay/animation = new( loc )
-	animation.icon_state = "blank"
-	animation.icon = 'icons/mob/mob.dmi'
-	animation.master = src
-	flick("h2monkey", animation)
+	PoolOrNew(/obj/effect/overlay/temp/monkeyify, get_turf(src))
 	sleep(22)
 	var/mob/living/carbon/monkey/O = new /mob/living/carbon/monkey( loc )
-	qdel(animation)
 
 	// hash the original name?
 	if(tr_flags & TR_HASHNAME)
@@ -188,16 +183,11 @@
 	icon = null
 	cut_overlays()
 	invisibility = INVISIBILITY_MAXIMUM
-	var/atom/movable/overlay/animation = new( loc )
-	animation.icon_state = "blank"
-	animation.icon = 'icons/mob/mob.dmi'
-	animation.master = src
-	flick("monkey2h", animation)
+	PoolOrNew(/obj/effect/overlay/temp/monkeyify/humanify, get_turf(src))
 	sleep(22)
 	var/mob/living/carbon/human/O = new( loc )
 	for(var/obj/item/C in O.loc)
 		O.equip_to_appropriate_slot(C)
-	qdel(animation)
 
 	dna.transfer_identity(O)
 	O.updateappearance(mutcolor_update=1)