cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-21 12:08:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

Replaces world.icon_size (and some magic numbers) with defines (#86819)

Browse Source 
## About The Pull Request

All usages of world.icon_size in code have been replaced with new
`ICONSIZE_X`, `ICONSIZE_Y` and `ICONSIZE_ALL` defines depending on
context

Replaces some "32" magic numbers with the defines

A few bits of code have been modified to split up x/y math as well

## Why It's Good For The Game

Magic number bad, code more readable, code more flexible and I'm told
there's an access cost to doing world.icon_size so minor performance
gains

## Changelog

🆑 tonty
code: made some code relating to the world's icon size more readable
/🆑

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
This commit is contained in:
tonty
2024-09-29 13:28:32 +00:00
committed by GitHub
co-authored by Ghom
parent 5a2971e83d
commit 3f0b4abb8d
92 changed files with 347 additions and 320 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/mapfluff/ruins/lavalandruin_code/puzzle.dm
+4 -4
View File
@@ -160,10 +160,10 @@
var/y = width - round((id - 1) / width)
var/x = ((id - 1) % width) + 1
var/x_start = 1 + (x - 1) * world.icon_size
var/x_end = x_start + world.icon_size - 1
var/y_start = 1 + ((y - 1) * world.icon_size)
var/y_end = y_start + world.icon_size - 1
var/x_start = 1 + (x - 1) * ICON_SIZE_X
var/x_end = x_start + ICON_SIZE_X - 1
var/y_start = 1 + ((y - 1) * ICON_SIZE_Y)
var/y_end = y_start + ICON_SIZE_Y - 1
var/icon/T = new(base_icon)
T.Crop(x_start,y_start,x_end,y_end)