From 3f92eefdaba86aee6842edce0b33c7e5ba085f29 Mon Sep 17 00:00:00 2001
From: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
Date: Mon, 20 Mar 2023 16:26:41 -0700
Subject: [PATCH] Define default tram length, light color [NO GBP] (#74125)

## About The Pull Request

Removes magic number from tram crossing calculation, makes it a define
instead. Uses standard light_color defines to better match other station
lighting.

## Why It's Good For The Game

Magic numbers bad. Consistency good.

## Changelog

No CL required, it's just a slight fix for
https://github.com/tgstation/tgstation/pull/74072
---
 code/__DEFINES/tram.dm                         |  2 ++
 .../industrial_lift/tram/tram_machinery.dm     | 18 +++++++++---------
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/code/__DEFINES/tram.dm b/code/__DEFINES/tram.dm
index 3717b289336..f70e000db0f 100644
--- a/code/__DEFINES/tram.dm
+++ b/code/__DEFINES/tram.dm
@@ -10,6 +10,8 @@
 #define XING_SIGNAL_DIRECTION_WEST "west-"
 #define XING_SIGNAL_DIRECTION_EAST "east-"
 
+#define XING_DEFAULT_TRAM_LENGTH 10
+
 /// Tram destinations/platforms
 #define TRAMSTATION_WEST 1
 #define TRAMSTATION_CENTRAL 2
diff --git a/code/modules/industrial_lift/tram/tram_machinery.dm b/code/modules/industrial_lift/tram/tram_machinery.dm
index fd187a646c8..d663dd64b50 100644
--- a/code/modules/industrial_lift/tram/tram_machinery.dm
+++ b/code/modules/industrial_lift/tram/tram_machinery.dm
@@ -143,7 +143,7 @@ GLOBAL_LIST_EMPTY(tram_doors)
 		if(!tram_part.travelling)
 			if(is_operational)
 				for(var/obj/machinery/crossing_signal/xing as anything in GLOB.tram_signals)
-					xing.set_signal_state(XING_STATE_AMBER, TRUE)
+					xing.set_signal_state(XING_STATE_MALF, TRUE)
 				for(var/obj/machinery/destination_sign/desto as anything in GLOB.tram_signs)
 					desto.icon_state = "[desto.base_icon_state][DESTINATION_OFF]"
 					desto.update_appearance()
@@ -247,11 +247,11 @@ GLOBAL_LIST_EMPTY(tram_doors)
 	subsystem_type = /datum/controller/subsystem/processing/fastprocess
 	light_range = 1.5
 	light_power = 3
-	light_color = COLOR_VIBRANT_LIME
+	light_color = LIGHT_COLOR_BABY_BLUE
 	luminosity = 1
 
-	/// green, amber, or red.
-	var/signal_state = XING_STATE_GREEN
+	/// green, amber, or red for tram, blue if it's emag, tram missing, etc.
+	var/signal_state = XING_STATE_MALF
 	/// The ID of the tram we control
 	var/tram_id = MAIN_STATION_TRAM
 	/// Weakref to the tram piece we control
@@ -468,7 +468,7 @@ GLOBAL_LIST_EMPTY(tram_doors)
 		tram_velocity_sign = tram.travel_direction & EAST ? 1 : -1
 
 	// How far away are we? negative if already passed.
-	var/approach_distance = tram_velocity_sign * (signal_pos - (tram_pos + 5))
+	var/approach_distance = tram_velocity_sign * (signal_pos - (tram_pos + (XING_DEFAULT_TRAM_LENGTH * 0.5)))
 
 	// Check for stopped state.
 	// Will kill the process since tram starting up will restart process.
@@ -525,13 +525,13 @@ GLOBAL_LIST_EMPTY(tram_doors)
 	var/new_color
 	switch(signal_state)
 		if(XING_STATE_MALF)
-			new_color = COLOR_BRIGHT_BLUE
+			new_color = LIGHT_COLOR_BABY_BLUE
 		if(XING_STATE_GREEN)
-			new_color = COLOR_VIBRANT_LIME
+			new_color = LIGHT_COLOR_VIVID_GREEN
 		if(XING_STATE_AMBER)
-			new_color = COLOR_YELLOW
+			new_color = LIGHT_COLOR_BRIGHT_YELLOW
 		else
-			new_color = COLOR_RED
+			new_color = LIGHT_COLOR_FLARE
 
 	set_light(l_on = TRUE, l_color = new_color)