[MIRROR] USE SIGNAL_HANDLER REEEEEE (#5921)

* use SIGNAL_HANDLER REEEEEE (#59242)

makes as many procs as i can find use the SIGNAL_HANDLER define which i assumed they all already did

* USE SIGNAL_HANDLER REEEEEE

Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>

code/game/objects/items/cards_ids.dm

@@ -787,6 +787,7 @@
 	update_label()
 
 /obj/item/card/id/advanced/proc/on_holding_card_slot_moved(obj/item/computer_hardware/card_slot/source, atom/old_loc, dir, forced)
+	SIGNAL_HANDLER
 	if(istype(old_loc, /obj/item/modular_computer/tablet))
 		UnregisterSignal(old_loc, COMSIG_ITEM_EQUIPPED, COMSIG_ITEM_DROPPED)
 

code/game/objects/items/chrono_eraser.dm

@@ -35,11 +35,11 @@
 				qdel(PA)
 			else
 				PA = new(src)
-				user.put_in_hands(PA)
+				INVOKE_ASYNC(user, /mob.proc/put_in_hands, PA)
 
 /obj/item/chrono_eraser/item_action_slot_check(slot, mob/user)
 	if(slot == ITEM_SLOT_BACK)
-		return 1
+		return TRUE
 
 /obj/item/gun/energy/chrono_gun
 	name = "T.E.D. Projection Apparatus"

code/game/objects/items/control_wand.dm

@@ -23,6 +23,7 @@
 	RegisterSignal(src, COMSIG_COMPONENT_NTNET_ACK, .proc/good_signal)
 
 /obj/item/door_remote/proc/bad_signal(datum/source, datum/netdata/data, error_code)
+	SIGNAL_HANDLER
 	if(QDELETED(data.user))
 		return // can't send a message to a missing user
 	if(error_code == NETWORK_ERROR_UNAUTHORIZED)
@@ -32,6 +33,7 @@
 
 
 /obj/item/door_remote/proc/good_signal(datum/source, datum/netdata/data, error_code)
+	SIGNAL_HANDLER
 	if(QDELETED(data.user))
 		return
 	var/toggled = data.data["data"]

code/game/objects/items/defib.dm

@@ -83,7 +83,7 @@
 	update_power()
 
 /obj/item/defibrillator/ui_action_click()
-	toggle_paddles()
+	INVOKE_ASYNC(src, .proc/toggle_paddles)
 
 //ATTACK HAND IGNORING PARENT RETURN VALUE
 /obj/item/defibrillator/attack_hand(mob/user, list/modifiers)

code/game/objects/items/devices/PDA/PDA.dm

@@ -1267,6 +1267,7 @@ GLOBAL_LIST_EMPTY(PDAs)
 		. += P
 
 /obj/item/pda/proc/pda_no_detonate()
+	SIGNAL_HANDLER
 	return COMPONENT_PDA_NO_DETONATE
 
 #undef PDA_SCANNER_NONE

code/game/objects/items/devices/geiger_counter.dm

@@ -37,7 +37,7 @@
 /obj/item/geiger_counter/Destroy()
 	STOP_PROCESSING(SSobj, src)
 	QDEL_NULL(soundloop)
-	
+
 	return ..()
 
 /obj/item/geiger_counter/process(delta_time)
@@ -211,6 +211,7 @@
 	listeningTo = user
 
 /obj/item/geiger_counter/cyborg/proc/redirect_rad_act(datum/source, amount)
+	SIGNAL_HANDLER
 	rad_act(amount)
 
 /obj/item/geiger_counter/cyborg/dropped()

code/game/objects/items/devices/megaphone.dm

@@ -35,6 +35,7 @@
 	UnregisterSignal(M, COMSIG_MOB_SAY)
 
 /obj/item/megaphone/proc/handle_speech(mob/living/carbon/user, list/speech_args)
+	SIGNAL_HANDLER
 	if (user.get_active_held_item() == src)
 		if(spamcheck > world.time)
 			to_chat(user, "<span class='warning'>\The [src] needs to recharge!</span>")

code/game/objects/items/devices/radio/intercom.dm

@@ -120,6 +120,7 @@
  * * source - the area that just had a power change.
  */
 /obj/item/radio/intercom/proc/AreaPowerCheck(datum/source)
+	SIGNAL_HANDLER
 	var/area/current_area = get_area(src)
 	if(!current_area)
 		on = FALSE

code/game/objects/items/flamethrower.dm

@@ -264,6 +264,7 @@
 	F.default_ignite(location,release_amount)
 
 /obj/item/flamethrower/proc/instant_refill()
+	SIGNAL_HANDLER
 	if(ptank)
 		var/datum/gas_mixture/tank_mix = ptank.return_air()
 		tank_mix.assert_gas(/datum/gas/plasma)

code/game/objects/items/food/misc.dm

@@ -192,6 +192,7 @@
 
 ///Prevents grilling burnt shit from well, burning.
 /obj/item/food/badrecipe/proc/OnGrill()
+	SIGNAL_HANDLER
 	return COMPONENT_HANDLED_GRILLING
 
 /obj/item/food/carrotfries

code/game/objects/items/implants/implant.dm

@@ -18,7 +18,7 @@
 	SEND_SIGNAL(src, COMSIG_IMPLANT_ACTIVATED)
 
 /obj/item/implant/ui_action_click()
-	activate("action_button")
+	INVOKE_ASYNC(src, .proc/activate, "action_button")
 
 /obj/item/implant/proc/can_be_implanted_in(mob/living/target)
 	if(issilicon(target))

code/game/objects/items/implants/implantuplink.dm

@@ -20,6 +20,7 @@
  * the component, so delete itself.
  */
 /obj/item/implant/uplink/proc/_component_removal(datum/source, datum/component/component)
+	SIGNAL_HANDLER
 	if(istype(component, /datum/component/uplink))
 		qdel(src)
 

code/game/objects/items/robot/robot_upgrades.dm

@@ -502,6 +502,7 @@
 	RegisterSignal(defib_instance, list(COMSIG_PARENT_QDELETING, COMSIG_MOVABLE_MOVED), .proc/on_defib_instance_qdel_or_moved)
 
 /obj/item/borg/upgrade/defib/backpack/proc/on_defib_instance_qdel_or_moved(obj/item/defibrillator/D)
+	SIGNAL_HANDLER
 	defib_instance = null
 	qdel(src)
 

code/game/objects/items/storage/bags.dm

@@ -143,6 +143,7 @@
 		listeningTo = null
 
 /obj/item/storage/bag/ore/proc/Pickup_ores(mob/living/user)
+	SIGNAL_HANDLER
 	var/show_message = FALSE
 	var/obj/structure/ore_box/box
 	var/turf/tile = user.loc

code/game/objects/items/storage/firstaid.dm

@@ -598,6 +598,7 @@
 
 ///freezes the organ and loops bodyparts like heads
 /obj/item/storage/organbox/proc/freeze(datum/source, obj/item/I)
+	SIGNAL_HANDLER
 	if(isorgan(I))
 		var/obj/item/organ/organ = I
 		organ.organ_flags |= ORGAN_FROZEN
@@ -611,6 +612,7 @@
 
 ///unfreezes the organ and loops bodyparts like heads
 /obj/item/storage/organbox/proc/unfreeze(datum/source, obj/item/I)
+	SIGNAL_HANDLER
 	if(isorgan(I))
 		var/obj/item/organ/organ = I
 		organ.organ_flags  &= ~ORGAN_FROZEN

code/game/objects/items/tanks/jetpack.dm

@@ -74,10 +74,11 @@
 	ion_trail.stop()
 	UnregisterSignal(user, COMSIG_MOVABLE_MOVED)
 	UnregisterSignal(user, COMSIG_MOVABLE_PRE_MOVE)
-	
+
 	user.remove_movespeed_modifier(/datum/movespeed_modifier/jetpack/fullspeed)
 
 /obj/item/tank/jetpack/proc/move_react(mob/user)
+	SIGNAL_HANDLER
 	if(!on)//If jet dont work, it dont work
 		return
 	if(!user || !user.client)//Don't allow jet self using
@@ -94,6 +95,7 @@
 		allow_thrust(0.01, user)
 
 /obj/item/tank/jetpack/proc/pre_move_react(mob/user)
+	SIGNAL_HANDLER
 	ion_trail.oldposition = get_turf(src)
 
 /obj/item/tank/jetpack/proc/allow_thrust(num, mob/living/user)

code/game/objects/objs.dm

@@ -190,6 +190,7 @@
 	ui_interact(user)
 
 /mob/proc/unset_machine()
+	SIGNAL_HANDLER
 	if(!machine)
 		return
 	UnregisterSignal(machine, COMSIG_PARENT_QDELETING)

code/game/objects/structures/training_machine.dm

@@ -142,6 +142,7 @@
  * Cleans up behavior for when the attached item is deleted or removed.
  */
 /obj/structure/training_machine/proc/on_attached_delete()
+	SIGNAL_HANDLER
 	UnregisterSignal(attached_item, COMSIG_PARENT_QDELETING)
 	vis_contents -= attached_item
 	attached_item = null