[MIRROR] USE SIGNAL_HANDLER REEEEEE (#5921)

* use SIGNAL_HANDLER REEEEEE (#59242)

makes as many procs as i can find use the SIGNAL_HANDLER define which i assumed they all already did

* USE SIGNAL_HANDLER REEEEEE

Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
This commit is contained in:
SkyratBot
2021-05-25 03:42:11 +01:00
committed by GitHub
co-authored by Kylerace
parent d4fcb06342
commit 456f347dfa
121 changed files with 199 additions and 34 deletions
+1
View File
@@ -1323,4 +1323,5 @@
/mob/living/carbon/proc/attach_rot(mapload)
SIGNAL_HANDLER
AddComponent(/datum/component/rot, 6 MINUTES, 10 MINUTES, 1)
@@ -785,6 +785,7 @@
/// The limb or the whole damn person we were grasping got deleted or dismembered, so we don't care anymore
/obj/item/self_grasp/proc/qdel_void()
SIGNAL_HANDLER
qdel(src)
/// We've already cleared that the bodypart in question is bleeding in [the place we create this][/mob/living/carbon/proc/grabbedby], so set up the connections
@@ -601,6 +601,7 @@
* Called on the COMSIG_COMPONENT_CLEAN_FACE_ACT signal
*/
/mob/living/carbon/human/proc/clean_face(datum/source, clean_types)
SIGNAL_HANDLER
if(!is_mouth_covered() && clean_lips())
. = TRUE
@@ -139,20 +139,24 @@
qdel(src)
/obj/item/dullahan_relay/proc/examinate_check(atom/source, mob/user)
SIGNAL_HANDLER
if(user.client.eye == src)
return COMPONENT_ALLOW_EXAMINATE
//Adds the owner to the list of hearers in hearers_in_view(), for visible/hearable on top of say messages
/obj/item/dullahan_relay/proc/include_owner(datum/source, list/processing_list, list/hearers)
SIGNAL_HANDLER
if(!QDELETED(owner))
hearers += owner
//Stops dullahans from gibbing when regenerating limbs
/obj/item/dullahan_relay/proc/unlist_head(datum/source, noheal = FALSE, list/excluded_zones)
SIGNAL_HANDLER
excluded_zones |= BODY_ZONE_HEAD
//Retrieving the owner's head for better ahealing.
/obj/item/dullahan_relay/proc/retrieve_head(datum/source, full_heal, admin_revive)
SIGNAL_HANDLER
if(admin_revive)
var/obj/item/bodypart/head/H = loc
var/turf/T = get_turf(owner)
@@ -101,6 +101,7 @@
H.update_body()
/datum/species/ethereal/proc/on_emp_act(mob/living/carbon/human/H, severity)
SIGNAL_HANDLER
EMPeffect = TRUE
spec_updatehealth(H)
to_chat(H, "<span class='notice'>You feel the light of your body leave you.</span>")
@@ -111,6 +112,7 @@
addtimer(CALLBACK(src, .proc/stop_emp, H), 20 SECONDS, TIMER_UNIQUE|TIMER_OVERRIDE) //We're out for 20 seconds
/datum/species/ethereal/proc/on_emag_act(mob/living/carbon/human/H, mob/user)
SIGNAL_HANDLER
if(emageffect)
return
emageffect = TRUE
@@ -671,6 +671,7 @@
playsound(get_turf(H), 'sound/misc/sadtrombone.ogg', 70, FALSE)
/datum/species/golem/bananium/proc/handle_speech(datum/source, list/speech_args)
SIGNAL_HANDLER
speech_args[SPEECH_SPANS] |= SPAN_CLOWN
/datum/species/golem/runic
@@ -644,6 +644,7 @@
return TRUE
/datum/species/jelly/stargazer/proc/unlink_mob(mob/living/M)
SIGNAL_HANDLER
var/link_id = linked_mobs.Find(M)
if(!(link_id))
return
@@ -132,6 +132,7 @@
/datum/species/synth/proc/handle_speech(datum/source, list/speech_args)
SIGNAL_HANDLER
if (isliving(source)) // yeah it's gonna be living but just to be clean
var/mob/living/L = source
if(fake_species && L.health > disguise_fail_health)
+4
View File
@@ -1664,6 +1664,7 @@
start_look_up()
/mob/living/proc/start_look_up()
SIGNAL_HANDLER
var/turf/ceiling = get_step_multiz(src, UP)
if(!ceiling) //We are at the highest z-level.
to_chat(src, "<span class='warning'>You can't see through the ceiling above you.</span>")
@@ -1685,6 +1686,7 @@
reset_perspective(ceiling)
/mob/living/proc/stop_look_up()
SIGNAL_HANDLER
reset_perspective()
/mob/living/proc/end_look_up()
@@ -1709,6 +1711,7 @@
start_look_down()
/mob/living/proc/start_look_down()
SIGNAL_HANDLER
var/turf/floor = get_turf(src)
var/turf/lower_level = get_step_multiz(floor, DOWN)
if(!lower_level) //We are at the lowest z-level.
@@ -1733,6 +1736,7 @@
reset_perspective(lower_level)
/mob/living/proc/stop_look_down()
SIGNAL_HANDLER
reset_perspective()
/mob/living/proc/end_look_down()
+1
View File
@@ -1007,6 +1007,7 @@
Remove(owner) //If the last shell is blown, destroy it.
/mob/living/silicon/ai/proc/disconnect_shell()
SIGNAL_HANDLER
if(deployed_shell) //Forcibly call back AI in event of things such as damage, EMP or power loss.
to_chat(src, "<span class='danger'>Your remote connection has been reset!</span>")
deployed_shell.undeploy()
@@ -952,6 +952,7 @@
aicamera.stored[i] = TRUE
/mob/living/silicon/robot/proc/charge(datum/source, amount, repairs)
SIGNAL_HANDLER
if(model)
model.respawn_consumable(src, amount * 0.005)
if(cell)
@@ -914,6 +914,7 @@
return "Unknown"
/mob/living/simple_animal/bot/mulebot/paranormal/proc/ghostmoved()
SIGNAL_HANDLER
visible_message("<span class='notice'>The ghostly figure vanishes...</span>")
UnregisterSignal(load, COMSIG_MOVABLE_MOVED)
unload(0)
@@ -202,6 +202,7 @@
///Updates the next mob in the chain to move to our last location, fixed the worm if somehow broken.
/mob/living/simple_animal/hostile/eldritch/armsy/proc/update_chain_links()
SIGNAL_HANDLER
if(!follow)
return
gib_trail()
@@ -54,6 +54,7 @@
to_chat(src, "<span class='danger'><B>Your powers are on cooldown! You must wait 20 seconds between bombs.</B></span>")
/mob/living/simple_animal/hostile/guardian/bomb/proc/kaboom(atom/source, mob/living/explodee)
SIGNAL_HANDLER
if(!istype(explodee))
return
if(explodee == src || explodee == summoner || hasmatchingsummoner(explodee))
@@ -71,6 +72,7 @@
UNREGISTER_BOMB_SIGNALS(A)
/mob/living/simple_animal/hostile/guardian/bomb/proc/display_examine(datum/source, mob/user, text)
SIGNAL_HANDLER
text += "<span class='holoparasite'>It glows with a strange <font color=\"[guardiancolor]\">light</font>!</span>"
#undef UNREGISTER_BOMB_SIGNALS
@@ -70,5 +70,6 @@
gravito_targets -= target
/mob/living/simple_animal/hostile/guardian/gravitokinetic/proc/__distance_check(atom/movable/AM, OldLoc, Dir, Forced)
SIGNAL_HANDLER
if(get_dist(src, AM) > gravity_power_range)
remove_gravity(AM)
@@ -43,6 +43,7 @@
RegisterSignal(src, COMSIG_MOVABLE_MOVED, .proc/goosement)
/mob/living/simple_animal/hostile/retaliate/goose/proc/goosement(atom/movable/AM, OldLoc, Dir, Forced)
SIGNAL_HANDLER
if(stat == DEAD)
return
if(prob(5) && random_retaliate)
@@ -219,7 +220,7 @@
/mob/living/simple_animal/hostile/retaliate/goose/vomit/goosement(atom/movable/AM, OldLoc, Dir, Forced)
. = ..()
if(vomiting)
vomit() // its supposed to keep vomiting if you move
INVOKE_ASYNC(src, .proc/vomit) // its supposed to keep vomiting if you move
return
if(prob(vomitCoefficient * 0.2))
vomit_prestart(vomitTimeBonus + 25)
@@ -299,6 +299,7 @@ Difficulty: Extremely Hard
/// Resurrects the target when they die by moving them and dusting a clone in their place, one life for another
/obj/item/resurrection_crystal/proc/resurrect(mob/living/carbon/user, gibbed)
SIGNAL_HANDLER
if(gibbed)
to_chat(user, "<span class='notice'>This power cannot be used if your entire mortal body is disintegrated...</span>")
return
@@ -306,12 +307,12 @@ Difficulty: Extremely Hard
var/typepath = user.type
var/mob/living/carbon/clone = new typepath(user.loc)
clone.real_name = user.real_name
user.dna.transfer_identity(clone)
INVOKE_ASYNC(user.dna, /datum/dna.proc/transfer_identity, clone)
clone.updateappearance(mutcolor_update=1)
var/turf/T = find_safe_turf()
user.forceMove(T)
user.revive(full_heal = TRUE, admin_revive = TRUE)
user.set_species(/datum/species/shadow)
INVOKE_ASYNC(user, /mob/living/carbon.proc/set_species, /datum/species/shadow)
to_chat(user, "<span class='notice'>You blink and find yourself in [get_area_name(T)]... feeling a bit darker.</span>")
clone.dust()
qdel(src)
@@ -413,6 +414,7 @@ Difficulty: Extremely Hard
/// Blocks movement from the status effect owner
/datum/status_effect/ice_block_talisman/proc/owner_moved()
SIGNAL_HANDLER
return COMPONENT_MOVABLE_BLOCK_PRE_MOVE
/datum/status_effect/ice_block_talisman/on_remove()
@@ -212,6 +212,7 @@
RegisterSignal(owner, COMSIG_PARENT_PREQDELETED, .proc/handle_mob_deletion)
/datum/action/consume/proc/handle_mob_deletion()
SIGNAL_HANDLER
stop_consuming() //Shit out the vored mob before u go go
///Try to consume the pulled mob