From 45725ebcc26d5f14b3969c2ee35daf2590d6c929 Mon Sep 17 00:00:00 2001 From: Lucy Date: Sun, 20 Oct 2024 11:12:12 -0400 Subject: [PATCH] PDA ringtones now show a balloon alert (#87278) ## About The Pull Request This makes it so receiving a PDA message will give the holder a balloon alert with their ringtone. ## Why It's Good For The Game PDA messages are often ignored due to not being noticed, as many players are more often focused on the main game screen (which runechat has somewhat normalized) than the chat window. This makes things more obvious that there's a PDA message. ## Changelog :cl: add: PDA ringtones now show a balloon alert to the PDA holder. /:cl: --- code/modules/modular_computers/computers/item/computer.dm | 7 +++++-- .../file_system/programs/messenger/messenger_program.dm | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/code/modules/modular_computers/computers/item/computer.dm b/code/modules/modular_computers/computers/item/computer.dm index 79ed186472a..74001a88524 100644 --- a/code/modules/modular_computers/computers/item/computer.dm +++ b/code/modules/modular_computers/computers/item/computer.dm @@ -555,7 +555,7 @@ playsound(src, sound, 50, TRUE) physical.loc.visible_message(span_notice("[icon2html(physical, viewers(physical.loc))] \The [src] displays a [caller.filedesc] notification: [alerttext]")) -/obj/item/modular_computer/proc/ring(ringtone) // bring bring +/obj/item/modular_computer/proc/ring(ringtone, list/balloon_alertees) // bring bring if(!use_energy()) return if(HAS_TRAIT(SSstation, STATION_TRAIT_PDA_GLITCHED)) @@ -565,7 +565,10 @@ ), 50, TRUE) else playsound(src, 'sound/machines/beep/twobeep_high.ogg', 50, TRUE) - audible_message("*[ringtone]*") + ringtone = "*[ringtone]*" + audible_message(ringtone) + for(var/mob/living/alertee in balloon_alertees) + alertee.balloon_alert(alertee, ringtone) /obj/item/modular_computer/proc/send_sound() playsound(src, 'sound/machines/terminal/terminal_success.ogg', 15, TRUE) diff --git a/code/modules/modular_computers/file_system/programs/messenger/messenger_program.dm b/code/modules/modular_computers/file_system/programs/messenger/messenger_program.dm index bec3ca91a07..1eeb54ff3b3 100644 --- a/code/modules/modular_computers/file_system/programs/messenger/messenger_program.dm +++ b/code/modules/modular_computers/file_system/programs/messenger/messenger_program.dm @@ -718,7 +718,7 @@ SEND_SIGNAL(computer, COMSIG_COMPUTER_RECEIVED_MESSAGE, sender_title, inbound_message, photo_message) if (alert_able && (!alert_silenced || is_rigged)) - computer.ring(ringtone) + computer.ring(ringtone, receievers) SStgui.update_uis(computer) update_pictures_for_all()