Full revert of #79995 (tri-ai station trait). Partal revert of #81681 (human ai) (#84850)

#79995 removed the verb and secrets button for no reason. This means you
can no longer decide to do tri-ai in the lobby, you have to do it next
round or make players suffer thru another init cycle.

**__In general systems that require things be decided the previous round
are really fucking annoying and should be minimized to only specific
things that absolutely have to for technical reason.__**

This is not one of them.

I do not have the time to redesign the station trait to make use of the
existing admin code so this is a full revert instead.

If the station trait is re-added, it should be done so without removing
the secrets button or admin verb.

#81681 had an undocumented and un-atmoized change, in that it removed a
job related signal needlessly, that undocumented change has been
reverted because this system used that signal.

@Fikou 
@JohnFulpWillard 

(also cc @tralezab and @Ghommie as you merged the reverted prs)
This commit is contained in:
Kyle Spier-Swenson
2024-07-12 16:07:09 -07:00
committed by GitHub
parent 7728652323
commit 45ca1717d0
8 changed files with 67 additions and 40 deletions
+5
View File
@@ -257,6 +257,11 @@ ADMIN_VERB(secrets, R_NONE, "Secrets", "Abuse harder than you ever have before w
return
holder.anon_names()
SSblackbox.record_feedback("nested tally", "admin_secrets_fun_used", 1, list("Anonymous Names"))
if("tripleAI")
if(!is_funmin)
return
holder.triple_ai()
SSblackbox.record_feedback("nested tally", "admin_secrets_fun_used", 1, list("Triple AI"))
if("onlyone")
if(!is_funmin)
return