[MIRROR] Fixes the issues with ghost role spawners being able to spawn userless bodies [MDB IGNORE] (#19817)

* Fixes the issues with ghost role spawners being able to spawn userless bodies

* Fixes da conflict yo

---------

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>

code/modules/mob_spawn/mob_spawn.dm

@@ -115,6 +115,9 @@
 	var/uses = 1
 	/// Does the spawner delete itself when it runs out of uses?
 	var/deletes_on_zero_uses_left = TRUE
+	/// A list of the ckeys that currently are trying to access this spawner, so that they can't try to spawn more than once (in case there's sleeps).
+	/// Static because you only really want to be able to spawn in one spawner at a time, obviously.
+	var/static/list/ckeys_trying_to_spawn
 
 	////descriptions
 
@@ -164,13 +167,18 @@
 	if(!SSticker.HasRoundStarted() || !loc)
 		return
 
-	// SKYRAT EDIT ADDITION
-	if(is_banned_from(user.ckey, BAN_GHOST_ROLE_SPAWNER)) // Ghost role bans
-		to_chat(user, "Error, you are banned from playing ghost roles!")
+	// We don't open the prompt more than once at a time.
+	if(LAZYFIND(ckeys_trying_to_spawn, user.ckey))
 		return
+
+	var/user_ckey = user.ckey // Just in case shenanigans happen, we always want to remove it from the list.
+	LAZYADD(ckeys_trying_to_spawn, user_ckey)
+
+	// SKYRAT EDIT ADDITION
 	if(restricted_species && !(user.client?.prefs?.read_preference(/datum/preference/choiced/species) in restricted_species))
 		var/incorrect_species = tgui_alert(user, "Current species preference incompatible, proceed with random appearance?", "Incompatible Species", list("Yes", "No"))
 		if(incorrect_species != "Yes")
+			LAZYREMOVE(ckeys_trying_to_spawn, user_ckey)
 			return
 	// SKYRAT EDIT END
 
@@ -180,21 +188,38 @@
 			prompt += " (Warning, You can no longer be revived!)"
 		var/ghost_role = tgui_alert(usr, prompt, buttons = list("Yes", "No"), timeout = 10 SECONDS)
 		if(ghost_role != "Yes" || !loc || QDELETED(user))
+			LAZYREMOVE(ckeys_trying_to_spawn, user_ckey)
 			return
 
 	if(!(GLOB.ghost_role_flags & GHOSTROLE_SPAWNER) && !(flags_1 & ADMIN_SPAWNED_1))
 		to_chat(user, span_warning("An admin has temporarily disabled non-admin ghost roles!"))
+		LAZYREMOVE(ckeys_trying_to_spawn, user_ckey)
 		return
 	if(uses <= 0 && !infinite_use) //just in case
 		to_chat(user, span_warning("This spawner is out of charges!"))
+		LAZYREMOVE(ckeys_trying_to_spawn, user_ckey)
 		return
 
 	if(is_banned_from(user.key, role_ban))
 		to_chat(user, span_warning("You are banned from this role!"))
+		LAZYREMOVE(ckeys_trying_to_spawn, user_ckey)
 		return
+	// SKYRAT EDIT ADDITION
+	if(is_banned_from(user.ckey, BAN_GHOST_ROLE_SPAWNER)) // Ghost role bans
+		to_chat(user, span_warning("Error, you are banned from playing ghost roles!"))
+		LAZYREMOVE(ckeys_trying_to_spawn, user_ckey)
+		return
+	// SKYRAT EDIT END
 	if(!allow_spawn(user, silent = FALSE))
+		LAZYREMOVE(ckeys_trying_to_spawn, user_ckey)
 		return
 	if(QDELETED(src) || QDELETED(user))
+		LAZYREMOVE(ckeys_trying_to_spawn, user_ckey)
+		return
+
+	if(uses <= 0) // Just in case something took longer than it should've and we got here after the uses went below zero.
+		to_chat(user, span_warning("This spawner is out of charges!"))
+		LAZYREMOVE(ckeys_trying_to_spawn, user_ckey)
 		return
 
 	create_from_ghost(user)
@@ -214,14 +239,24 @@
 	user.mind = null // dissassociate mind, don't let it follow us to the next life
 
 	var/created = create(user)
+	var/user_ckey = user.ckey // Just in case shenanigans happen, we always want to remove it from the list.
+	LAZYREMOVE(ckeys_trying_to_spawn, user_ckey) // We do this AFTER the create() so that we're basically sure that the user won't be in their ghost body anymore, so they can't click on the spawner again.
+
 	if(!created)
+		uses += 1 // Refund use because we didn't actually spawn anything
+
 		if(isnull(created)) // If we explicitly return FALSE instead of just not returning a mob, we don't want to spam the admins
 			CRASH("An instance of [type] didn't return anything when creating a mob, this might be broken!")
 
-		uses += 1 // Refund use because we didn't actually spawn anything
-
 	check_uses() // Now we check if the spawner should delete itself or not
 
+/obj/effect/mob_spawn/ghost_role/create(mob/mob_possessor, newname)
+	if(!mob_possessor.key) // This is in the scenario that the server is somehow lagging, or someone fucked up their code, and we try to spawn the same person in twice. We'll simply not spawn anything and CRASH(), so that we report what happened.
+		CRASH("Attempted to create an instance of [type] with a mob that had no ckey attached to it, which isn't supported by ghost role spawners!")
+
+	return ..()
+
+
 /obj/effect/mob_spawn/ghost_role/special(mob/living/spawned_mob, mob/mob_possessor)
 	. = ..()
 	if(mob_possessor)