mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-26 06:29:23 +01:00
Fixes Ice Slipping, Refactors noslip mechanics, Allows magboots to prevent slip slides (but not the slip itself) (#73948)
## About The Pull Request Code changes: - Fixes #73946 , Ice Slipping not going forever as intended - Detailed in the issue report. Ice slide slip was replaced from a stun to a knockdown, but it relied on it being a stun to function. I replaced it back with an immobilize and incapacitate, reduced to 1 second to prevent cheese. - Refactors noslip mechanics - Changes noslip and noslip_ice from a clothing flag to a clothing trait, as the trait already existed and was used by MODsuits. Also added noslip_slide, which prevents all sliding from slips like lube. - Refactors magboots - Refactored and modernized magboot code. Mostly cleanup, like using base icon state, updating appearance, etc. - Fixes speed potioned magboots not maintaining the speed boost after a toggle - Adds a helper for adding or removing clothing traits from existing, (potentially) worn items. - `TRAIT_NEGATE_GRAVITY` now always updates gravity on signal, no longer requiring a manual call after. Balance change: - Magboots now prevent sliding on permafrost (outside icebox). - This is mainly to give them more of a purpose on Icebox. - Magboot snow prevent sliding on ice (or lube). You will still slip. - Slipping over ice or lube will knock you down as before, but will not send you across the room. - See https://tgstation13.org/phpBB/viewtopic.php?t=33217. ## Why It's Good For The Game Magboots justification: This makes Magboots much less of a "noob trab" for engineers fire-fighting in the Supermatter room. Most engineers believe themselves to be completely save to the Supermatter's pull with magboots, however "wet ice" will still send you flying into the crystal. I think it is an inconsistency, seeing as it protects you from other forms of forced movement like gravitational pulls. However making them pure no-slip seemed a bit too far to me, so the knockdown still occurs. ## Changelog 🆑 Melbert balance: Magboots will now protect you from sliding on ice. It will not stop the slip, though. fix: "Ice sliding" (from patches of permafrost ice) will now correctly slide you until you reach a non-ice patch. fix: Speed potioned magboots maintain their speed booster after toggling them refactor: Refactored magboots. refactor: Refactored noslip mechanics. /🆑
This commit is contained in:
@@ -258,7 +258,7 @@
|
||||
duration = 100
|
||||
|
||||
/datum/status_effect/watercookie/on_apply()
|
||||
ADD_TRAIT(owner, TRAIT_NOSLIPWATER,"watercookie")
|
||||
ADD_TRAIT(owner, TRAIT_NO_SLIP_WATER,"watercookie")
|
||||
return ..()
|
||||
|
||||
/datum/status_effect/watercookie/tick()
|
||||
@@ -266,7 +266,7 @@
|
||||
T.MakeSlippery(TURF_WET_WATER, min_wet_time = 10, wet_time_to_add = 5)
|
||||
|
||||
/datum/status_effect/watercookie/on_remove()
|
||||
REMOVE_TRAIT(owner, TRAIT_NOSLIPWATER,"watercookie")
|
||||
REMOVE_TRAIT(owner, TRAIT_NO_SLIP_WATER,"watercookie")
|
||||
|
||||
/datum/status_effect/metalcookie
|
||||
id = "metalcookie"
|
||||
@@ -527,11 +527,11 @@
|
||||
colour = "blue"
|
||||
|
||||
/datum/status_effect/stabilized/blue/on_apply()
|
||||
ADD_TRAIT(owner, TRAIT_NOSLIPWATER, "slimestatus")
|
||||
ADD_TRAIT(owner, TRAIT_NO_SLIP_WATER, "slimestatus")
|
||||
return ..()
|
||||
|
||||
/datum/status_effect/stabilized/blue/on_remove()
|
||||
REMOVE_TRAIT(owner, TRAIT_NOSLIPWATER, "slimestatus")
|
||||
REMOVE_TRAIT(owner, TRAIT_NO_SLIP_WATER, "slimestatus")
|
||||
|
||||
/datum/status_effect/stabilized/metal
|
||||
id = "stabilizedmetal"
|
||||
|
||||
Reference in New Issue
Block a user