cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-24 21:48:39 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Assorted changes to job assignment code and logging." (#85929)

Browse Source 
Reverts tgstation/tgstation#85308

![image](https://github.com/user-attachments/assets/eb74d378-29da-44f0-bd14-89c95654cb4e)
This commit is contained in:
Kyle Spier-Swenson
2024-08-17 15:26:08 -07:00
committed by GitHub
parent 4ce1f048fe
commit 4d1639b04c
69 changed files with 295 additions and 323 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/unit_tests/anonymous_themes.dm
+1 -1
View File
@@ -12,7 +12,7 @@
client.prefs.write_preference(GLOB.preference_entries[/datum/preference/name/real_name], "Prefs Biddle")
human.apply_prefs_job(client, SSjob.get_job_type(/datum/job/assistant))
human.apply_prefs_job(client, SSjob.GetJobType(/datum/job/assistant))
TEST_ASSERT_NOTEQUAL(human.real_name, "Prefs Biddle", "apply_prefs_job didn't randomize human name with an anonymous theme")
TEST_ASSERT_EQUAL(client.prefs.read_preference(/datum/preference/name/real_name), "Prefs Biddle", "Anonymous theme overrode original prefs")
code/modules/unit_tests/dummy_spawn.dm
+1 -1
View File
@@ -16,7 +16,7 @@
/datum/unit_test/dummy_spawn_outfit/Run()
var/mob/living/carbon/human/dummy/lad = allocate(/mob/living/carbon/human/dummy)
for(var/datum/job/one_two_three as anything in subtypesof(/datum/job))
var/datum/job/can_you_hear_this = SSjob.get_job_type(one_two_three)
var/datum/job/can_you_hear_this = SSjob.GetJobType(one_two_three)
if(!can_you_hear_this)
log_test("\tJob type [one_two_three] could not be retrieved from SSjob")
continue
code/modules/unit_tests/security_officer_distribution.dm
+1 -1
View File
@@ -68,7 +68,7 @@
var/mob/living/carbon/human/new_character = allocate(/mob/living/carbon/human/consistent)
new_character.mind_initialize()
new_character.mind.set_assigned_role(SSjob.get_job_type(/datum/job/security_officer))
new_character.mind.set_assigned_role(SSjob.GetJobType(/datum/job/security_officer))
new_player.new_character = new_character
new_player.mock_client = mock_client
code/modules/unit_tests/traitor.dm
+1 -1
View File
@@ -11,7 +11,7 @@
possible_jobs += rank
for(var/job_name in possible_jobs)
var/datum/job/job = SSjob.get_job(job_name)
var/datum/job/job = SSjob.GetJob(job_name)
var/mob/living/player = allocate(job.spawn_type)
player.mind_initialize()
var/datum/mind/mind = player.mind
code/modules/unit_tests/traitor_mail_content_check.dm
+1 -1
View File
@@ -5,6 +5,6 @@
var/mob/living/carbon/human/person = allocate(/mob/living/carbon/human/consistent)
person.mind_initialize()
var/obj/item/mail/traitor/test_mail = allocate(/obj/item/mail/traitor)
person.mind.set_assigned_role(SSjob.get_job_type(/datum/job/captain))
person.mind.set_assigned_role(SSjob.GetJobType(/datum/job/captain))
test_mail.initialize_for_recipient(person.mind)
TEST_ASSERT_EQUAL(test_mail.contents.len, 0, "/obj/item/mail/traitor should not have items after initialize_for_recipient proc!")