cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-23 21:18:37 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixes runtime when creating a stack out of a stack with full hands with a stack below you (#96582)

Browse Source 
## About The Pull Request

Stack's made, eaten by other stack the second it's created, tries to
initialize materials with an amount of 0, predictably runtimes. Don't
bother with materials if the stack's already eaten.

## Why It's Good For The Game

<img width="677" height="93" alt="image"
src="https://github.com/user-attachments/assets/79e6c8f0-b3e3-4b8d-9bcb-00974f3545f0"
/>

## Changelog
🆑

fix: fixed a runtime when creating a stack via another stack that's then
eaten by another stack when it's created

/🆑
This commit is contained in:
Leland Kemble
2026-06-21 22:19:17 +02:00
committed by GitHub
parent 2034800f3a
commit 4e1c2d5154
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/game/objects/items/stacks/stack.dm
+7 -6
View File
@@ -475,12 +475,13 @@
if(isstack(created))
var/obj/item/stack/crafted_stack = created
if(recipe.res_amount > 0 && recipe.req_amount != recipe.res_amount)
var/scale = recipe.req_amount / recipe.res_amount
for(var/mat in result_mats)
result_mats[mat] *= scale
crafted_stack.mats_per_unit = SSmaterials.get_material_set_cache(result_mats)
crafted_stack.update_custom_materials()
if(crafted_stack.amount) // If our stack's been emptied, it means another stack's already eaten it, and that stack'll deal with materials
if(recipe.res_amount > 0 && recipe.req_amount != recipe.res_amount)
var/scale = recipe.req_amount / recipe.res_amount
for(var/mat in result_mats)
result_mats[mat] *= scale
crafted_stack.mats_per_unit = SSmaterials.get_material_set_cache(result_mats)
crafted_stack.update_custom_materials()
else
created.set_custom_materials(result_mats, recipe.req_amount * multiplier)