From 4e341bdd97b902b2e7f3769d50fcd0eb9b1c485f Mon Sep 17 00:00:00 2001 From: Roxy <75404941+TealSeer@users.noreply.github.com> Date: Sat, 10 May 2025 18:33:12 -0400 Subject: [PATCH] Fix flaky runtime related to ghoul limbs (#3776) ## About The Pull Request Ghoul limbs drop meat instead of the limb when they come off and they do that by `qdel`ing in `drop_limb` but if `drop_limb` was originally called as part of `Destroy` they'll qdel twice and you can't do that and it runtimes ## Why It's Good For The Game Fix flaky CI failure ## Proof Of Testing Trust ## Changelog N/A --- .../modules/bodyparts/code/ghoul_bodyparts.dm | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/modular_skyrat/modules/bodyparts/code/ghoul_bodyparts.dm b/modular_skyrat/modules/bodyparts/code/ghoul_bodyparts.dm index 8947fdbc86c..bb1c5a2445c 100644 --- a/modular_skyrat/modules/bodyparts/code/ghoul_bodyparts.dm +++ b/modular_skyrat/modules/bodyparts/code/ghoul_bodyparts.dm @@ -105,7 +105,8 @@ . = newMeat // Return MEAT - qdel(src) + if(!QDELETED(src)) + qdel(src) /obj/item/bodypart/arm/left/mutant/ghoul/drop_limb(special, dismembered, move_to_floor = TRUE) ..() // Create Meat, Remove Limb @@ -116,7 +117,8 @@ . = newMeat // Return MEAT - qdel(src) + if(!QDELETED(src)) + qdel(src) /obj/item/bodypart/leg/right/mutant/ghoul/drop_limb(special, dismembered, move_to_floor = TRUE) ..() // Create Meat, Remove Limb @@ -127,7 +129,8 @@ . = newMeat // Return MEAT - qdel(src) + if(!QDELETED(src)) + qdel(src) /obj/item/bodypart/leg/left/mutant/ghoul/drop_limb(special, dismembered, move_to_floor = TRUE) ..() // Create Meat, Remove Limb @@ -138,7 +141,8 @@ . = newMeat // Return MEAT - qdel(src) + if(!QDELETED(src)) + qdel(src) #undef GHOUL_BRUTE_MODIFIER #undef GHOUL_BURN_MODIFIER