cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-07-22 05:25:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Alternative job titles in the Occupations screen actually used in-game (#9420)

Browse Source 
* Added alt jobs names actually doing something.

* Also add late join announcements.

* Fix custom roles showing up first in crew monitor

* Cleanup to match upstream changes

* Updates from review, also improve both tgui manifests

* Compromise for Skyrat edit notes vs JSX vs linter

* Compromise for optimization vs not making a horrible mess of passing client around

* Follow module rules

* Revert no longer true changed to customization readme

* Update dme

* Fixed comments for alt titles
This commit is contained in:
Tastyfish
2021-11-27 22:18:45 -05:00
committed by GitHub
parent 778bc205ea
commit 4eefadc8b4
10 changed files with 103 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/mob/dead/new_player/new_player.dm
+6 -3
View File
@@ -259,11 +259,14 @@
humanc = character //Let's retypecast the var to be human,
if(humanc) //These procs all expect humans
GLOB.data_core.manifest_inject(humanc)
// BEGIN SKYRAT EDIT CHANGE - ALTERNATIVE_JOB_TITLES
var/chosen_rank = humanc.client?.prefs.alt_job_titles[rank] || rank
GLOB.data_core.manifest_inject(humanc, humanc.client)
if(SSshuttle.arrivals)
SSshuttle.arrivals.QueueAnnounce(humanc, rank)
SSshuttle.arrivals.QueueAnnounce(humanc, chosen_rank)
else
announce_arrival(humanc, rank)
announce_arrival(humanc, chosen_rank)
// END SKYRAT EDIT CHANGE - customization
AddEmploymentContract(humanc)
humanc.increment_scar_slot()