cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-07-20 20:45:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Fixes complex lights not handling moving well, renames lighting defines (#26484)

Browse Source 
* Fixes complex lights not handling moving well, renames lighting defines (#81423)

## About The Pull Request

[Fixes static lights not
moving](https://github.com/tgstation/tgstation/commit/ffef43c05a55dae414ef94558ecf9b9df709ded7)

Worked fine when the owner moved, but if the owner was inside something
else, it would try and trigger an update on the PARENT's lights, which
are obviously not us.

[Renames MOVABLE_LIGHT and STATIC_LIGHT to better describe what they
do](https://github.com/tgstation/tgstation/commit/de73a63bd4d97783c69c95370726d1c253ffb8fe)

People keep trying to change the lighting system of lamps and it makes
me mad.
I choose OVERLAY_LIGHT and COMPLEX_LIGHT here, I couldn't figure out a
better name for turf matrix lighting. Suggestions welcome

## Why It's Good For The Game

Closes #80005
Hopefully improves understanding of lighting at a glance
## Changelog
🆑
fix: Fixes fancy lights not updating their source location when picked
up and moved
/🆑

* Oh well

---------

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
This commit is contained in:
SkyratBot
2024-02-12 23:25:22 +01:00
committed by GitHub
parent 71f96ec7e2
commit 4f53ec2660
73 changed files with 113 additions and 109 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/wiremod/shell/bot.dm
+1 -1
View File
@@ -9,7 +9,7 @@
icon_state = "setup_medium_box"
density = FALSE
light_system = MOVABLE_LIGHT
light_system = OVERLAY_LIGHT
light_on = FALSE
/obj/structure/bot/Initialize(mapload)
code/modules/wiremod/shell/compact_remote.dm
+1 -1
View File
@@ -11,7 +11,7 @@
worn_icon_state = "electronic"
lefthand_file = 'icons/mob/inhands/items/devices_lefthand.dmi'
righthand_file = 'icons/mob/inhands/items/devices_righthand.dmi'
light_system = MOVABLE_LIGHT_DIRECTIONAL
light_system = OVERLAY_LIGHT_DIRECTIONAL
light_on = FALSE
/obj/item/compact_remote/Initialize(mapload)
code/modules/wiremod/shell/controller.dm
+1 -1
View File
@@ -12,7 +12,7 @@
worn_icon_state = "electronic"
lefthand_file = 'icons/mob/inhands/items/devices_lefthand.dmi'
righthand_file = 'icons/mob/inhands/items/devices_righthand.dmi'
light_system = MOVABLE_LIGHT_DIRECTIONAL
light_system = OVERLAY_LIGHT_DIRECTIONAL
light_on = FALSE
/obj/item/controller/Initialize(mapload)
code/modules/wiremod/shell/dispenser.dm
+1 -1
View File
@@ -9,7 +9,7 @@
icon_state = "setup_drone_arms"
density = FALSE
light_system = MOVABLE_LIGHT
light_system = OVERLAY_LIGHT
light_on = FALSE
var/max_weight = WEIGHT_CLASS_NORMAL
code/modules/wiremod/shell/drone.dm
+1 -1
View File
@@ -10,7 +10,7 @@
maxHealth = 300
health = 300
living_flags = 0
light_system = MOVABLE_LIGHT_DIRECTIONAL
light_system = OVERLAY_LIGHT_DIRECTIONAL
light_on = FALSE
/mob/living/circuit_drone/Initialize(mapload)
code/modules/wiremod/shell/gun.dm
+1 -1
View File
@@ -11,7 +11,7 @@
ammo_type = list(/obj/item/ammo_casing/energy/wiremod_gun)
cell_type = /obj/item/stock_parts/cell/emproof/wiremod_gun
item_flags = NONE
light_system = MOVABLE_LIGHT_DIRECTIONAL
light_system = OVERLAY_LIGHT_DIRECTIONAL
light_on = FALSE
automatic_charge_overlays = FALSE
trigger_guard = TRIGGER_GUARD_ALLOW_ALL
code/modules/wiremod/shell/keyboard.dm
+1 -1
View File
@@ -6,7 +6,7 @@
worn_icon_state = "electronic"
lefthand_file = 'icons/mob/inhands/items/devices_lefthand.dmi'
righthand_file = 'icons/mob/inhands/items/devices_righthand.dmi'
light_system = MOVABLE_LIGHT_DIRECTIONAL
light_system = OVERLAY_LIGHT_DIRECTIONAL
light_on = FALSE
/obj/item/keyboard_shell/Initialize(mapload)
code/modules/wiremod/shell/moneybot.dm
+1 -1
View File
@@ -9,7 +9,7 @@
icon_state = "setup_large"
density = FALSE
light_system = MOVABLE_LIGHT
light_system = OVERLAY_LIGHT
light_on = FALSE
var/stored_money = 0
code/modules/wiremod/shell/scanner.dm
+1 -1
View File
@@ -11,7 +11,7 @@
worn_icon_state = "electronic"
lefthand_file = 'icons/mob/inhands/items/devices_lefthand.dmi'
righthand_file = 'icons/mob/inhands/items/devices_righthand.dmi'
light_system = MOVABLE_LIGHT_DIRECTIONAL
light_system = OVERLAY_LIGHT_DIRECTIONAL
light_on = FALSE
/obj/item/wiremod_scanner/Initialize(mapload)
code/modules/wiremod/shell/server.dm
+1 -1
View File
@@ -10,7 +10,7 @@
icon_state = "setup_stationary"
density = TRUE
light_system = MOVABLE_LIGHT
light_system = OVERLAY_LIGHT
light_on = FALSE
/obj/structure/server/Initialize(mapload)