From 54cb66c7becae9f64f7a2843beafc18acea6a818 Mon Sep 17 00:00:00 2001 From: OrbisAnima Date: Wed, 29 Oct 2025 12:34:13 -0300 Subject: [PATCH] [Fix] Corrects exploit that allowed to use departamental budget to buy goodie items (#93668) ## About The Pull Request Adds a check on wherever its self paid or not when buying stuff as self paid on the budgetering pda program, so it works like a regular cargo console ## Why It's Good For The Game Well, behaviors should be consistent, and this looks more like an oversight. Its also the only way to order goodies with departamental budgets atm, and the comments on the goodies flag seem to heavily imply the intent is for this not to happen. ## Proof of work ### Before image image ### After image image ## Changelog :cl: fix: solves an exploit that allowed users to buy goodie packs with the pda budget program /:cl: --- .../modular_computers/file_system/programs/budgetordering.dm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/modules/modular_computers/file_system/programs/budgetordering.dm b/code/modules/modular_computers/file_system/programs/budgetordering.dm index 27fd838af30..a181a702fad 100644 --- a/code/modules/modular_computers/file_system/programs/budgetordering.dm +++ b/code/modules/modular_computers/file_system/programs/budgetordering.dm @@ -259,7 +259,7 @@ if(isnull(reason) || ..()) return - if(id_card_customer?.registered_account?.account_job) //Find a budget to pull from + if(id_card_customer?.registered_account?.account_job && !self_paid) //Find a budget to pull from var/datum/bank_account/personal_department = SSeconomy.get_dep_account(id_card_customer.registered_account.account_job.paycheck_department) if(!(personal_department.account_holder == "Cargo Budget")) var/choice = tgui_alert(usr, "Which department are you requesting this for?", "Choose request department", list("Cargo Budget", "[personal_department.account_holder]"))