From 55f6d34930024ac46a666284e1427d790166d574 Mon Sep 17 00:00:00 2001 From: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Date: Sun, 24 Dec 2023 15:04:16 -0800 Subject: [PATCH] Change quirks_taken from nested tally to tally (#80479) Nested tally is overkill and requires that this be handled especially in Superset. Version is not updated as the data for this is the exact same. I recommend running this query after merge (CC @MrStonedOne): ```sql UPDATE feedback SET key_type = 'tally' WHERE key_name = 'quirks_taken' ``` --- code/controllers/subsystem/processing/quirks.dm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/controllers/subsystem/processing/quirks.dm b/code/controllers/subsystem/processing/quirks.dm index 7facefdfe37..916c8850e19 100644 --- a/code/controllers/subsystem/processing/quirks.dm +++ b/code/controllers/subsystem/processing/quirks.dm @@ -89,7 +89,7 @@ PROCESSING_SUBSYSTEM_DEF(quirks) var/datum/quirk/quirk_type = quirks[quirk_name] if(ispath(quirk_type)) if(user.add_quirk(quirk_type, override_client = applied_client)) - SSblackbox.record_feedback("nested tally", "quirks_taken", 1, list("[quirk_name]")) + SSblackbox.record_feedback("tally", "quirks_taken", 1, "[quirk_name]") else stack_trace("Invalid quirk \"[quirk_name]\" in client [applied_client.ckey] preferences") applied_client.prefs.all_quirks -= quirk_name