cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-25 22:19:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Dissallow non R_VAREDIT admins from using VV topic and modifying traits (#90763)

Browse Source 
## About The Pull Request

So
A) Modifying traits pretty self explanatory was a missing check
B) imo given the type of data that can be seen in vv this shouldnt be
exposed to literally anyone with an admin datum especially considering
actually showing it to someone else and editing it is R_admin and
r_varedit

the giant diff is just indentation change
Showing vv to other players is unaffected by this

## Changelog
🆑
fix: fixed some vv issues
/🆑

---------

Co-authored-by: TiviPlus <572233640+TiviPlus@users.noreply.com>
Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com>
This commit is contained in:
TiviPlus
2025-04-30 19:16:42 +00:00
committed by GitHub
co-authored by TiviPlus SmArtKar
parent 1d60e99e2a
commit 569d25a8de
3 changed files with 110 additions and 121 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/admin/verbs/admin.dm
+2
View File
@@ -100,6 +100,8 @@ ADMIN_VERB(cmd_admin_check_player_exp, R_ADMIN, "Player Playtime", "View player
/datum/admins/proc/modify_traits(datum/D)
if(!D)
return
if(!check_rights(R_VAREDIT))
return
var/add_or_remove = input("Remove/Add?", "Trait Remove/Add") as null|anything in list("Add","Remove")
if(!add_or_remove)