From 56db6396e9f05b99e52d7f59a1037022afa08a20 Mon Sep 17 00:00:00 2001 From: MrStonedOne Date: Thu, 8 Sep 2016 07:58:20 -0700 Subject: [PATCH] Fix some istypes to handle clients properly --- code/datums/datumvars.dm | 16 ++++++++-------- code/modules/admin/verbs/modifyvariables.dm | 16 ++++++++-------- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/code/datums/datumvars.dm b/code/datums/datumvars.dm index 10b1886e89e..ed93eb9369a 100644 --- a/code/datums/datumvars.dm +++ b/code/datums/datumvars.dm @@ -389,14 +389,14 @@ body else if (isfile(value)) html += "[html_encode(name)] = '[value]'" + else if (istype(value, /client)) + var/client/C = value + html += "[html_encode(name)] \ref[value] = [C] [C.type]" + else if (istype(value, /datum)) var/datum/D = value html += "[html_encode(name)] \ref[value] = [D.type]" - else if (istype(value, /client)) - var/client/C = value - html += "[html_encode(name)] \ref[value] = [C] [C.type]" -// else if (istype(value, /list)) var/list/L = value html += "[html_encode(name)] = /list ([L.len])" @@ -529,8 +529,8 @@ body return var/D = locate(href_list["datumedit"]) - if(!istype(D,/datum) && !istype(D,/client)) - usr << "This can only be used on instances of types /client or /datum" + if(!istype(D,/datum)) + usr << "This can only be used on datums" return modify_variables(D, href_list["varnameedit"], 1) @@ -540,8 +540,8 @@ body return var/D = locate(href_list["datumchange"]) - if(!istype(D,/datum) && !istype(D,/client)) - usr << "This can only be used on instances of types /client or /datum" + if(!istype(D,/datum)) + usr << "This can only be used on datums" return modify_variables(D, href_list["varnamechange"], 0) diff --git a/code/modules/admin/verbs/modifyvariables.dm b/code/modules/admin/verbs/modifyvariables.dm index 4b4a3364196..1a006fce385 100644 --- a/code/modules/admin/verbs/modifyvariables.dm +++ b/code/modules/admin/verbs/modifyvariables.dm @@ -471,6 +471,10 @@ var/list/VVckey_edit = list("key", "ckey") var_value = "\icon[var_value]" class = "icon" + else if(istype(var_value,/client)) + usr << "Variable appears to be CLIENT." + class = "cancel" + else if(istype(var_value,/atom) || istype(var_value,/datum)) usr << "Variable appears to be TYPE." class = "type" @@ -479,10 +483,6 @@ var/list/VVckey_edit = list("key", "ckey") usr << "Variable appears to be LIST." class = "list" - else if(istype(var_value,/client)) - usr << "Variable appears to be CLIENT." - class = "cancel" - else usr << "Variable appears to be FILE." class = "file" @@ -535,6 +535,10 @@ var/list/VVckey_edit = list("key", "ckey") var_value = "\icon[var_value]" default = "icon" + else if(istype(var_value,/client)) + usr << "Variable appears to be CLIENT." + default = "cancel" + else if(istype(var_value,/atom) || istype(var_value,/datum)) usr << "Variable appears to be TYPE." default = "type" @@ -543,10 +547,6 @@ var/list/VVckey_edit = list("key", "ckey") usr << "Variable appears to be LIST." default = "list" - else if(istype(var_value,/client)) - usr << "Variable appears to be CLIENT." - default = "cancel" - else usr << "Variable appears to be FILE." default = "file"