From 581b38c1a879c69ffdbabdcd458cb076badf37ca Mon Sep 17 00:00:00 2001 From: SkyratBot <59378654+SkyratBot@users.noreply.github.com> Date: Tue, 10 Jan 2023 16:33:18 +0100 Subject: [PATCH] [MIRROR] Fixes a bug with drifting improperly stopping [MDB IGNORE] (#18626) * Fixes a bug with drifting improperly stopping (#72588) ## About The Pull Request You would hold a direction when you hit a wall, step, have the newt move blocked by your still living component, and then sit there floating In the last fix I did here I removed an unregister off loop pausing, which was leading to conflicting component additions and so runtimes. I've moved it to an unreg off loop deletion only, to avoid the old runtime and still preserve the existing desired behavior ## Why It's Good For The Game Fixes stepping after a drift movement. It looked really dumb and now it's gone Fixes https://github.com/tgstation/tgstation/issues/71454 ## Changelog :cl: fix: You can now properly start drifting after moving out of a drift /:cl: * Fixes a bug with drifting improperly stopping Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> --- code/datums/components/drift.dm | 1 + 1 file changed, 1 insertion(+) diff --git a/code/datums/components/drift.dm b/code/datums/components/drift.dm index 58bcff8acdf..3a2d98dda9b 100644 --- a/code/datums/components/drift.dm +++ b/code/datums/components/drift.dm @@ -127,6 +127,7 @@ /datum/component/drift/proc/loop_death(datum/source) SIGNAL_HANDLER drifting_loop = null + UnregisterSignal(parent, COMSIG_MOVABLE_NEWTONIAN_MOVE) // We won't block a component from replacing us anymore /datum/component/drift/proc/handle_move(datum/source, old_loc) SIGNAL_HANDLER