From 5871a9a722babfc79d3a3cc6f2d25a6b3a3abd0d Mon Sep 17 00:00:00 2001
From: spookydonut <github@spooksoftware.com>
Date: Thu, 5 Mar 2020 19:44:27 +0800
Subject: [PATCH] Small usability addition to Genetics DNA console interface.
 (#49689)

* Small usability addition to Genetics DNA console interface.

* Highlight individual gene buttons that are incomplete
---
 code/game/machinery/computer/dna_console.dm | 11 +++++++++--
 html/browser/scannernew.css                 |  9 +++++++++
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/code/game/machinery/computer/dna_console.dm b/code/game/machinery/computer/dna_console.dm
index 0a15070c4cc..ae7773fb3dc 100644
--- a/code/game/machinery/computer/dna_console.dm
+++ b/code/game/machinery/computer/dna_console.dm
@@ -523,7 +523,10 @@
 			for(var/i in 1 to DNA_SEQUENCE_LENGTH)
 				var/num = 1+(i-1)*2
 				var/genenum = num+(DNA_SEQUENCE_LENGTH*2*(block-1))
-				temp_html += "<td><div class='statusLine'><span class='dnaBlockNumber'><a href='?src=[REF(src)];task=pulsegene;num=[genenum];alias=[alias];'>[sequence[num]]</span></a></div></td>"
+				if(sequence[num] == "X")
+					temp_html += "<td><div class='statusLine'><span class='dnaBlockNumber'><a class='incompleteBlock' href='?src=[REF(src)];task=pulsegene;num=[genenum];alias=[alias];'>[sequence[num]]</span></a></div></td>"
+				else
+					temp_html += "<td><div class='statusLine'><span class='dnaBlockNumber'><a href='?src=[REF(src)];task=pulsegene;num=[genenum];alias=[alias];'>[sequence[num]]</span></a></div></td>"
 			temp_html += "</tr><tr>"
 			for(var/i in 1 to DNA_SEQUENCE_LENGTH)
 				temp_html += "<td><div class='statusLine'>|</div></td>"
@@ -531,7 +534,11 @@
 			for(var/i in 1 to DNA_SEQUENCE_LENGTH)
 				var/num = i*2
 				var/genenum = num+(DNA_SEQUENCE_LENGTH*2*(block-1))
-				temp_html += "<td><div class='statusLine'><span class='dnaBlockNumber'><a href='?src=[REF(src)];task=pulsegene;num=[genenum];alias=[alias];'>[sequence[num]]</span></a></div></td>"
+
+				if(sequence[num] == "X")
+					temp_html += "<td><div class='statusLine'><span class='dnaBlockNumber'><a class='incompleteBlock' href='?src=[REF(src)];task=pulsegene;num=[genenum];alias=[alias];'>[sequence[num]]</span></a></div></td>"
+				else
+					temp_html += "<td><div class='statusLine'><span class='dnaBlockNumber'><a href='?src=[REF(src)];task=pulsegene;num=[genenum];alias=[alias];'>[sequence[num]]</span></a></div></td>"
 			temp_html += "</tr></table></div>"
 		temp_html += "<br><br><br><br><br>"
 	else
diff --git a/html/browser/scannernew.css b/html/browser/scannernew.css
index 9e9f8ce1f48..25d4994bd5a 100644
--- a/html/browser/scannernew.css
+++ b/html/browser/scannernew.css
@@ -14,6 +14,15 @@
 	font-family: Fixed, monospace;
 	float: left;
 }
+a.incompleteBlock
+{
+	background: #8a4040;
+}
+a.incompleteBlock:hover
+{
+	color: #40628a;
+	background: #ffffff;
+}
 img.selected
 {
 	border: 1px solid blue;