cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-23 13:10:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix FaxBond not notifying for new faxes (#96990)

Browse Source 
## About The Pull Request

Using a (DCS) signal was a nice idea but it ran into the problem of spam
filters on telecomms machines, if each subscribed PDA is responsible for
sending the (PDA message) signal to themselves (and because there is
always at least 5 instances of head PDAs stored in `SSwardrobe`) only
the first one gets through before telecomms refuses to send the rest.
This moves it from a DCS signal registered on the fax machine and
handled on the PDA to a system where PDAs register themselves with the
fax machine and when it receives a fax it builds a single message signal
addressed to all the targets and sends that instead.

## Why It's Good For The Game

Fixes #96902 

## Changelog
🆑
fix: fixed FaxBond not sending notifications when faxes are received
/🆑
This commit is contained in:
Roxy
2026-07-16 23:12:43 +02:00
committed by GitHub
parent 02fd3e979e
commit 58caf75e0c
2 changed files with 36 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/modular_computers/file_system/programs/faxnotif.dm
+4 -30
View File
@@ -14,7 +14,7 @@
var/list/connected_faxes = list()
/**
* Proc for subscribing to faxes. Registers needed signal and updates fax related vars for program. Includes type checking.
* Proc for subscribing to faxes. Adds weakref to fax's listeners and updates fax related vars for program. Includes type checking.
* Arguments:
* * target - [/datum/computer_file/program/proc/tap] proc target, can be anything
*/
@@ -25,7 +25,7 @@
var/our_id = target.fax_id
if(!connected_faxes[our_id])
RegisterSignal(target, COMSIG_FAX_MESSAGE_RECEIVED, PROC_REF(on_fax_message_received))
LAZYSET(target.fax_listeners, REF(src), WEAKREF(src))
var/list/fax_info = list()
var/area/our_area = get_area(target)
@@ -38,7 +38,7 @@
return TRUE
/**
* Disconnects a fax given its ID (if it was connected before), removing it from a list and unregistering relevant signal
* Disconnects a fax given its ID (if it was connected before), removing it from the relevant lists.
* Arguments:
* * fax_id - fax id to disconnect from our PDA
*/
@@ -50,36 +50,10 @@
var/datum/weakref/fax_ref = fax_info["ref"]
var/obj/machinery/fax/our_fax = fax_ref.resolve()
if (our_fax)
UnregisterSignal(our_fax, COMSIG_FAX_MESSAGE_RECEIVED)
LAZYREMOVE(our_fax.fax_listeners, REF(src))
connected_faxes -= fax_id
/**
* Signal handler for [COMSIG_FAX_MESSAGE_RECEIVED].
* Arguments:
* * receiver - [/obj/machinery/fax] that received a message
* * message_source - name of a sender
*/
/datum/computer_file/program/faxbond/proc/on_fax_message_received(obj/machinery/fax/receiver, message_source)
SIGNAL_HANDLER
var/id = receiver.fax_id
var/list/fax_info = connected_faxes[id]
if (fax_info["muted"])
return
var/datum/computer_file/program/messenger/messenger = locate() in computer.stored_files
var/datum/signal/subspace/messaging/tablet_message/signal = new(receiver, list(
"fakename" = "Fax Notificator",
"fakejob" = "PDA Program",
"message" = "Your fax [receiver.fax_name] has received a new message from [message_source]",
"targets" = list(messenger),
"automated" = TRUE
))
INVOKE_ASYNC(signal, TYPE_PROC_REF(/datum/signal/subspace, send_to_receivers))
/datum/computer_file/program/faxbond/Destroy()
. = ..()
for(var/fax in connected_faxes)