From 5a3d9d883f801c26294ac8e5f8d0d11764e238c3 Mon Sep 17 00:00:00 2001 From: Jordie0608 Date: Sat, 21 Feb 2015 21:46:42 +1100 Subject: [PATCH] Warning check before sorting long lists in vv --- code/modules/admin/verbs/modifyvariables.dm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/code/modules/admin/verbs/modifyvariables.dm b/code/modules/admin/verbs/modifyvariables.dm index 3f66e4721a2..79ce1fb1f6a 100644 --- a/code/modules/admin/verbs/modifyvariables.dm +++ b/code/modules/admin/verbs/modifyvariables.dm @@ -136,6 +136,12 @@ var/list/VVckey_edit = list("key", "ckey") /client/proc/mod_list(var/list/L, atom/O, original_name, objectvar) if(!check_rights(R_VAREDIT)) return if(!istype(L,/list)) src << "Not a List." + + if(L.len > 1000) + var/confirm = alert(src, "The list you're trying to edit is very long, continuing may crash the server.", "Warning", "Continue", "Abort") + if(confirm != "Continue") + return + var/list/names = sortList(L) var/variable = input("Which var?","Var") as null|anything in names + "(ADD VAR)"