From 54ee75044d4848e63a60dfc2413d483ee30ad020 Mon Sep 17 00:00:00 2001 From: ninjanomnom Date: Tue, 18 Jun 2019 21:47:51 -0400 Subject: [PATCH 1/2] Adds some guidelines regarding large/wip pull requests --- .github/CONTRIBUTING.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index e14c5d16240..d40bdcc0ec1 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -394,6 +394,10 @@ There is no strict process when it comes to merging pull requests. Pull requests * Please explain why you are submitting the pull request, and how you think your change will be beneficial to the game. Failure to do so will be grounds for rejecting the PR. +* If your pull request is not finished make sure it is at least testable in a live environment. Pull requests that do not at least meet this requirement will be closed. You may request a maintainer reopen the pull request when you're ready, or make a new one. + +* Maintainers may close pull requests that are deemed to be substantialy flawed. For example pull requests which would need major rewrites to match our quality guidelines. You should take some time to discuss with maintainers or other contributors on how to improve the change. + ## Porting features/sprites/sounds/tools from other codebases If you are porting features/tools from other codebases, you must give them credit where it's due. Typically, crediting them in your pull request and the changelog is the recommended way of doing it. Take note of what license they use though, porting stuff from AGPLv3 and GPLv3 codebases are allowed. From 133d294ea631b6ac4a57a92830f31090e39f9f4b Mon Sep 17 00:00:00 2001 From: ninjanomnom Date: Wed, 19 Jun 2019 17:52:02 -0400 Subject: [PATCH 2/2] Steals mso's suggestion regarding large pull requests --- .github/CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index d40bdcc0ec1..5443410d5e3 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -396,7 +396,7 @@ There is no strict process when it comes to merging pull requests. Pull requests * If your pull request is not finished make sure it is at least testable in a live environment. Pull requests that do not at least meet this requirement will be closed. You may request a maintainer reopen the pull request when you're ready, or make a new one. -* Maintainers may close pull requests that are deemed to be substantialy flawed. For example pull requests which would need major rewrites to match our quality guidelines. You should take some time to discuss with maintainers or other contributors on how to improve the change. +* While we have no issue helping contributors (and especially new contributors) bring reasonably sized contributions up to standards via the pull request review process, larger contributions are expected to pass a higher bar of completeness and code quality *before* you open a pull request. Maintainers may close such pull requests that are deemed to be substantially flawed. You should take some time to discuss with maintainers or other contributors on how to improve the changes. ## Porting features/sprites/sounds/tools from other codebases