From 5e311990c34e451b2aa016ea5fd0c1eb8784c1ab Mon Sep 17 00:00:00 2001 From: Ghom <42542238+Ghommie@users.noreply.github.com> Date: Sun, 23 Feb 2025 19:25:37 +0100 Subject: [PATCH] [NO GBP] Fixing trophy fishes not loading mats (#89623) ## About The Pull Request For some reason, that either wasn't an issue before, or it always was and I did not fix it. Either way, `List()` is a proc and `material_path` variable is being read as an arg called "material_path" which is what the key is being set to, instead of the stored value of the variable, I think. ## Why It's Good For The Game Fixing stuff. ## Changelog :cl: fix: Fixing loaded trophy fishes possibly not having materials. /:cl: --- code/controllers/subsystem/persistence/trophy_fishes.dm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/code/controllers/subsystem/persistence/trophy_fishes.dm b/code/controllers/subsystem/persistence/trophy_fishes.dm index e7e0b635a2b..211bb849c69 100644 --- a/code/controllers/subsystem/persistence/trophy_fishes.dm +++ b/code/controllers/subsystem/persistence/trophy_fishes.dm @@ -27,8 +27,9 @@ fish.update_size_and_weight(data[PERSISTENCE_FISH_SIZE], data[PERSISTENCE_FISH_WEIGHT]) var/material_path = text2path(data[PERSISTENCE_FISH_MATERIAL]) if(material_path) - //setting the list inside the proccall doesn't seem to work - var/list/mat_list = list(material_path = fish.weight) + //setting the list otherwise seems to cause some issues, thank you Byond. + var/list/mat_list = list() + mat_list[material_path] = fish.weight fish.set_custom_materials(mat_list) fish.persistence_load(data) fish.name = data[PERSISTENCE_FISH_NAME]